[Woo POS][Design System] Update error icon size

[jaclync]

Part of #15234

Description

This pull request focuses on improving the consistency of error icon sizes based on the new design guide 1qcjzXitBHU7xPnpCOWnNM-fi-1114_19201, plus spacing tweaks in its use cases. The key changes include the introduction of a new enumeration for error icon sizes and adjustments to spacing constants.

Introduction of POSErrorAndAlertIconSize Enumeration:

• WooCommerce/Classes/POS/Utils/POSErrorAndAlertIconSize.swift: Added a new enumeration POSErrorAndAlertIconSize to define small, medium, and large sizes for error and alert icons. This change standardizes the icon sizes across the application.

Updates to Error Icon Sizes:

• WooCommerce/Classes/POS/Presentation/Reusable Views/POSErrorExclamationMark.swift: Modified POSErrorExclamationMark to use the new POSErrorAndAlertIconSize enumeration for defining icon sizes.
• WooCommerce/Classes/POS/Presentation/Reusable Views/POSErrorXMark.swift: Updated POSErrorXMark to utilize the POSErrorAndAlertIconSize enumeration for setting the icon size.

Adjustments to Spacing and Layout:

• WooCommerce/Classes/POS/Presentation/CardReaderConnection/UI States/PointOfSaleItemListErrorView.swift: Adjusted the spacing and layout in PointOfSaleItemListErrorView to use consistent spacing constants and the new icon size.
• WooCommerce/Classes/POS/Presentation/CardReaderConnection/UI States/Reader Messages/PointOfSaleCardPresentPaymentLayout.swift: Updated spacing constants in PointOfSaleCardPresentPaymentLayout to ensure consistent layout.

Steps to reproduce

• Turn off network connection
• Enter POS with at least one variable product --> the product list loading error UI should match the design (except for the Products header)
• Turn on network connection and reload item list
• Turn off network connection
• Tap on a variable product --> the variation list loading error UI should match the design
• Go back to the product list, scroll to the bottom --> the infinite scroll error card should have the ! icon fitting the image size
• Add item(s) to cart and check out --> the order sync error should match the design

Testing information

I tested the order validation error (< minimum payment amount), and payment error with an invalid order amount.

Screenshots

Item list loading error (design 1qcjzXitBHU7xPnpCOWnNM-fi-1076_15843):

products	variations

Infinite scroll loading error:

Order sync error (design 1qcjzXitBHU7xPnpCOWnNM-fi-1096_16832)	valiadation error

Payment error (design 1qcjzXitBHU7xPnpCOWnNM-fi-1096_18311) (just to ensure the icon size matches):

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added. of

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr15245-e8f0665
	Version	21.8
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	e8f0665
	App Center Build	WooCommerce - Prototype Builds #13140

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[iamgabrielma]

LGTM! There is one small issue with the text on the "try again" button when infinite scroll fails, and a question:

• Question: We use "retry" on the product/variations buttons while we've changed to "try again" in other places. Is this on purpose?

• "Try.." does seem to get cut off in any sizing (even smaller fonts):

[jaclync]

• Question: We use "retry" on the product/variations buttons while we've changed to "try again" in other places. Is this on purpose?

Good point, I asked design in 1qcjzXitBHU7xPnpCOWnNM-fi-1076_15843#1146628827.

[jaclync]

• "Try.." does seem to get cut off in any sizing (even smaller fonts):

Good catch, I can reproduce and replaced the hard-coded max width with a modifier to fit width to content in e8f0665:

no accessibility font size	biggest font size