Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue showing order details from push notifications #15247

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Feb 25, 2025

Closes: #15242

Description

This PR adds a small delay as a workaround for the issue when displaying order details fails after switching stores on iOS 18 devices.

Steps to reproduce

  1. Log in to a test store on a physical device running iOS 18 and above.
  2. On the web place an order for another store that is connected to the same WPCom account.
  3. When the push notification of the order comes on the device, tap on it.
  4. Notice that the app switches to the new store and navigates to the detail page of the new order successfully.

Testing information

Tested on both iPhone 16 Pro iOS 18.1.1 and iPad Pro iOS 18.2 and confirmed that navigation to the order details screen upon tapping push notifications works correctly.

Screenshots

ScreenRecording_02-25-2025.10-54-30_1.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: bug A confirmed bug. feature: notifications Related to notifications or notifs. labels Feb 25, 2025
@itsmeichigo itsmeichigo added this to the 21.8 ❄️ milestone Feb 25, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 25, 2025

1 Warning
⚠️ This PR is assigned to the milestone 21.8 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@itsmeichigo itsmeichigo changed the title Add delay before showing secondary column to ensure order details bei… FIx issue showing order details from push notifications Feb 25, 2025
@itsmeichigo itsmeichigo marked this pull request as ready for review February 25, 2025 04:27
@itsmeichigo itsmeichigo changed the title FIx issue showing order details from push notifications Fix issue showing order details from push notifications Feb 25, 2025
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15247-2c6340c
Version21.8
Bundle IDcom.automattic.alpha.woocommerce
Commit2c6340c
App Center BuildWooCommerce - Prototype Builds #13141
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@selanthiraiyan selanthiraiyan self-assigned this Feb 25, 2025
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM. 👍

I tested on an iPhone 13 Pro Max running iOS 18.1.1 and it works as expected. 🚢

@itsmeichigo itsmeichigo merged commit 6a05397 into release/21.8 Feb 25, 2025
29 checks passed
@itsmeichigo itsmeichigo deleted the fix/15242-push-notification-handling branch February 25, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: notifications Related to notifications or notifs. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants