Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POS] Improve Get Support #15252

Merged
merged 4 commits into from
Feb 26, 2025
Merged

[POS] Improve Get Support #15252

merged 4 commits into from
Feb 26, 2025

Conversation

toupper
Copy link
Contributor

@toupper toupper commented Feb 25, 2025

Closes: #15191

Description

With this PR we improve the Get Support form of the POS by:

  • Avoid tapping outside the Get support modal dismisses it and loses your progress when typing the ticket contents.
  • Pre-populate the site address in get support
  • Disable autocorrection and capitalization in the site address on the support form

Steps to reproduce

  1. Go to POS
  2. Tap on Get Support
  3. Check that the above is working

Testing information

See above

Screenshots

ScreenRecording_02-25-2025.16-23-52_1.MP4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

Summary by CodeRabbit

  • New Features
    • The support form now requires a designated close action instead of allowing swipe-to-dismiss, ensuring a more intentional interaction.
    • The form is updated to automatically apply a default site context for improved consistency.
    • The site address input has been refined by disabling autocorrection and auto-capitalization, allowing for more precise text entry.

@toupper toupper added this to the 21.9 milestone Feb 25, 2025
Copy link

coderabbitai bot commented Feb 25, 2025

Walkthrough

The changes modify how the support form behaves and is initialized. In the PointOfSaleDashboardView, the support form sheet now uses the .interactiveDismissDisabled(true) modifier to prevent swipe-to-dismiss and the SupportForm view model is initialized with an additional defaultSite parameter from the session manager. In the SupportForm, two modifiers have been added to the site address TextField to disable autocorrection and prevent automatic capitalization. These updates affect the presentation control flow and input handling within the support form.

Changes

File(s) Change Summary
WooCommerce/Classes/.../PointOfSaleDashboardView.swift - Added .interactiveDismissDisabled(true) to support form sheet presentation.
- Updated SupportFormViewModel initialization to include defaultSite from ServiceLocator.stores.sessionManager.defaultSite.
WooCommerce/Classes/.../SupportForm.swift - Applied .autocorrectionDisabled(true) and .textInputAutocapitalization(.never) modifiers to the site address TextField.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant D as Dashboard View
    participant S as Support Form
    participant VM as SupportFormViewModel

    U->>D: Tap support button
    D->>S: Present support form (interactive dismiss disabled)
    S->>VM: Initialize view model with defaultSite parameter
    U->>S: Enter site address (no autocorrect, no auto-capitalization)
    U->>S: Press close button to dismiss
    S->>D: Dismiss support form
Loading

Poem

I'm a rabbit with a hop so light,
Delighted by changes shining bright.
No more swipe-away surprises,
With a new view model that nicely rises.
Fields now know their case and tone,
Cheers to progress, feel right at home!
🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da488d5 and 0653a92.

📒 Files selected for processing (2)
  • WooCommerce/Classes/POS/Presentation/PointOfSaleDashboardView.swift (2 hunks)
  • WooCommerce/Classes/ViewRelated/Dashboard/Settings/Help/SupportForm/SupportForm.swift (1 hunks)
🔇 Additional comments (6)
WooCommerce/Classes/ViewRelated/Dashboard/Settings/Help/SupportForm/SupportForm.swift (2)

121-122: Great usability improvement for URL input.

These modifiers enhance the user experience when entering site addresses by preventing unwanted text corrections and capitalization, which is ideal for URLs.


121-122: Great improvement to the site address input field.

Adding autocorrection and capitalization disabling for the site address field ensures users can accurately type URLs without unwanted system corrections. This addresses the PR objective to prevent unintended modifications to site addresses.

WooCommerce/Classes/POS/Presentation/PointOfSaleDashboardView.swift (4)

80-80: Prevents accidental dismissal, preserving user input.

This change ensures users won't lose their support ticket content by accidentally tapping outside the modal, directly addressing the PR objective.


123-124: Pre-populates site address for a streamlined experience.

Passing the default site from the session manager to the support form view model will help pre-populate the site address field, saving users time and reducing input errors.


80-80: Excellent UX improvement to prevent accidental dismissal.

This change prevents users from accidentally dismissing the support form by tapping outside of it, addressing the first PR objective. Users must now use the "Done" button to dismiss the form, which prevents accidental loss of entered information.


123-124: Good UX enhancement with pre-populated site address.

Pre-populating the site address from the session manager's default site streamlines the support form experience for users, directly addressing the second PR objective. This saves users time and ensures accurate site information in support tickets.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15252-0653a92
Version21.8
Bundle IDcom.automattic.alpha.woocommerce
Commit0653a92
App Center BuildWooCommerce - Prototype Builds #13152
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks for sorting this one :shipit:

@toupper toupper merged commit e83f6d3 into trunk Feb 26, 2025
20 of 21 checks passed
@toupper toupper deleted the issue/15191-pos-improve-get-support branch February 26, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Improve Get Support form
3 participants