-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POS] Improve Get Support #15252
[POS] Improve Get Support #15252
Conversation
WalkthroughThe changes modify how the support form behaves and is initialized. In the PointOfSaleDashboardView, the support form sheet now uses the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant D as Dashboard View
participant S as Support Form
participant VM as SupportFormViewModel
U->>D: Tap support button
D->>S: Present support form (interactive dismiss disabled)
S->>VM: Initialize view model with defaultSite parameter
U->>S: Enter site address (no autocorrect, no auto-capitalization)
U->>S: Press close button to dismiss
S->>D: Dismiss support form
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (6)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks for sorting this one
Closes: #15191
Description
With this PR we improve the Get Support form of the POS by:
Steps to reproduce
Testing information
See above
Screenshots
ScreenRecording_02-25-2025.16-23-52_1.MP4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:
Summary by CodeRabbit