-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Codable Unit Tests for ProductImageStatus
, ProductImageAssetType
and ProductOrVariationID
#15253
base: feat/save-product-image-upload-statuses-in-user-defaults
Are you sure you want to change the base?
Conversation
…class to a different file
…s' into feat/save-product-image-upload-statuses-in-user-defaults-codable-conformance-unit-tests
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
…s' into feat/save-product-image-upload-statuses-in-user-defaults-codable-conformance-unit-tests
XCTAssertEqual(variationID, decodedVariationID) | ||
} | ||
|
||
func test_decoding_unknown_type_throws_error() throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Paolo, It looks like this unit test is failing in CI. Could you kindly take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sharma. Ready for another take!
…s' into feat/save-product-image-upload-statuses-in-user-defaults-codable-conformance-unit-tests
Part 2 of the changes needed for product image upload in the background.
Before merging this PR, make sure to merge this one.
Description
This pull request introduces new unit tests to ensure the correct encoding and decoding of various product and image-related entities within the
Networking
module.In particular:
ProductImageStatus
ProductImageAssetType
ProductOrVariationID
Testing information
Just unit tests should pass. ✅
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:
@coderabbitai review