Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch null content errors #21673

Merged
merged 3 commits into from
Feb 7, 2025
+4 −3
Merged

fix: Catch null content errors #21673

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3db7018
fix: Catch null content errors
dcalhoun Feb 7, 2025
257e008
docs: Add release note
dcalhoun Feb 7, 2025
3c28b1a
build: Update GutenbergKit ref
dcalhoun Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
-----
* [*] Fix unselectable group blocks in the experimental editor [https://github.com/wordpress-mobile/GutenbergKit/pull/68]
* [*] Prevent resetting content in the experimental editor when the device orientation changes [#21662]
* [*] Fix an interiment experimental editor crash while saving changes [#21673]

25.7
-----
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ google-play-services-auth = '20.4.1'
google-services = '4.4.2'
gravatar = '2.2.0'
greenrobot-eventbus = '3.3.1'
gutenberg-kit = 'trunk-7a9a66ce400ef1baaa2d098c0f8c95ffe1f42f81'
gutenberg-kit = '80-5c06c93df87aec38c6114766ccd3fda502c8dc77'
gutenberg-mobile = 'v1.121.0'
indexos-media-for-mobile = '43a9026f0973a2f0a74fa813132f6a16f7499c3a'
jackson-databind = '2.12.7.1'
Expand Down
4 changes: 2 additions & 2 deletions ...itor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergKitEditorFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,9 +331,9 @@ public Pair<CharSequence, CharSequence> getTitleAndContent(CharSequence original
final Pair<CharSequence, CharSequence>[] result = new Pair[1];
final CountDownLatch latch = new CountDownLatch(1);

mGutenbergView.getTitleAndContent(new TitleAndContentCallback() {
mGutenbergView.getTitleAndContent(originalContent, new TitleAndContentCallback() {
@Override
public void onResult(@Nullable String title, @NonNull String content) {
public void onResult(@NonNull CharSequence title, @NonNull CharSequence content) {
result[0] = new Pair<>(title, content);
latch.countDown();
}
Expand Down