Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom coingecko url #3275

Conversation

valentinoConti
Copy link
Contributor

Description

Adds a new optional prop to the Connect component to use a custom coingecko URL

Copy link

netlify bot commented Feb 13, 2025

👷 Deploy request for wormhole-connect pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9b946bd

Copy link

netlify bot commented Feb 13, 2025

👷 Deploy request for wormhole-connect-mainnet pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9b946bd

yuli-ferna
yuli-ferna previously approved these changes Feb 13, 2025
Copy link
Collaborator

@yuli-ferna yuli-ferna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@artursapek artursapek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've been trying to keep the config organized. for example, there is the ui key with lots of properties inside it.

rather than having multiple coingecko-related properties on the top level, can we start a coingecko key which is a similar object containing multiple properties?

@yuli-ferna
Copy link
Collaborator

yuli-ferna commented Feb 13, 2025

we've been trying to keep the config organized. for example, there is the ui key with lots of properties inside it.

rather than having multiple coingecko-related properties on the top level, can we start a coingecko key which is a similar object containing multiple properties?

@artursapek
Like this?:
coinGecko: { apiKey?: string, customUrl?: string}

@artursapek
Copy link
Collaborator

we've been trying to keep the config organized. for example, there is the ui key with lots of properties inside it.
rather than having multiple coingecko-related properties on the top level, can we start a coingecko key which is a similar object containing multiple properties?

@artursapek Like this?: coinGecko: { apiKey?: string, customUrl?: string}

that looks pretty gud

@aadam-10 aadam-10 merged commit 7b53442 into wormhole-foundation:development Feb 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants