-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard: update consts #191
Conversation
c8c5b4a
to
2ee5f4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few structure things that could lead to bugs in your react code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting close - main thing is that as
doesn't make the data safe to use, it just overrides the type safety. would probably be best to get all of the backend code using the same helper coalesce that env var into the type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just missed one spot and maybe clean up that function name and then should be good? 🤞
eb6f99e
to
c5ed397
Compare
This PR does the following: