Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: update consts #191

Merged
merged 2 commits into from
Jan 25, 2024
Merged

dashboard: update consts #191

merged 2 commits into from
Jan 25, 2024

Conversation

panoel
Copy link
Contributor

@panoel panoel commented Jan 22, 2024

This PR does the following:

  • removes karura from testnet watchers
  • updates testnet endpoints shown on the dashboard for missed and signed VAAs in the monitor section
  • testnet missing VAAs cloud function no longer alarms to slack.

@panoel panoel force-pushed the update_testnet_consts branch 6 times, most recently from c8c5b4a to 2ee5f4a Compare January 23, 2024 17:16
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few structure things that could lead to bugs in your react code

@panoel panoel requested review from bingyuyap and evan-gray January 23, 2024 20:33
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting close - main thing is that as doesn't make the data safe to use, it just overrides the type safety. would probably be best to get all of the backend code using the same helper coalesce that env var into the type

Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just missed one spot and maybe clean up that function name and then should be good? 🤞

@panoel panoel force-pushed the update_testnet_consts branch from eb6f99e to c5ed397 Compare January 25, 2024 21:37
@panoel panoel merged commit ede02f2 into main Jan 25, 2024
3 checks passed
@panoel panoel deleted the update_testnet_consts branch January 25, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants