-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmwasm: added shutdown contracts tests #4257
base: main
Are you sure you want to change the base?
Conversation
b902cc2
to
daedbab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed the CosmWasm tests as I was responsible for writing the interchain tests.
daedbab
to
7733aca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving the CosmWasm tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just confirm the reason for adding the cfg_attr
lines in the source files? I'm assuming it's to prevent the compiler from optimising those functions out for the tests?
Hey @djb15, the cfg_attrs are to quell the lint/clippy warnings that were arising when running the tests with no default features where those code paths are unused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good! Also confirmed that cfg_attr
does what's intended (adding allow(dead_code)
when default features disabled for testing)
Description
This PR adds comprehensive test coverage for the shutdown cw-wormhole contract, which serves as a safety mechanism for temporarily disabling the main contract in case of security incidents. The changes include both interchain integration tests and cw-multi-test based tests.
Changes
Purpose
This test coverage addition is a preliminary step before upcoming modifications to the cw-wormhole contract's state management. Having thorough test coverage in place will help ensure the safety and correctness of the future state management changes that are needed.
Test Scenarios
This pr was created jointly with @joelsmith-2019 where he contributed the ICT tests and I focused on the cw-multi-test