Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync light and dark theme with system on Linux #460

Open
bannert1337 opened this issue Feb 26, 2025 · 14 comments
Open

Sync light and dark theme with system on Linux #460

bannert1337 opened this issue Feb 26, 2025 · 14 comments

Comments

@bannert1337
Copy link
Contributor

This is related to issue #365

On Linux it currently does not sync the theme with the system. At least on KDE Plasma 6.3.1.

I can implement this, if you like. I use Linux across various devices and can test it.

@crschnick
Copy link
Member

By sync you mean the theme changing while XPipe is open and you change the dark mode setting in KDE? Or when XPipe is not running

@bannert1337
Copy link
Contributor Author

Both. When XPipe is started, it should apply the current system theme and also while it's running it should listen for changes and adapt. As described in #365 the use case is pretty common. I also have my system configured to switch between light and dark theme depending on sun rise and sun set. At day, I want to burn my eyes and at night I want to rest my eyes 😂

@crschnick
Copy link
Member

Both cases should work already, the only possibility is that the theme detection code itself doesn't work. Does that work on other systems for you besides KDE?

@bannert1337
Copy link
Contributor Author

I will try that out for different DEs and get back to you later!

@bannert1337
Copy link
Contributor Author

@crschnick
Copy link
Member

Recording.2025-02-26.230027.mp4

Works for me on Ubuntu 24 Gnome and EndevaourOS

@crschnick
Copy link
Member

Just to clarify, did you test this on two different systems or on one with two desktop environments?

@bannert1337
Copy link
Contributor Author

I created a new VM with CachyOS and Gnome

@crschnick
Copy link
Member

So I tested further. It works on Ubuntu Gnome but not Fedora Gnome ... I will have to figure out the exact versions

@crschnick
Copy link
Member

In the end this will be a bug report to the JavaFX devs, I can't do anything about this myself. What we can do is compile a list where it works and where it doesn't.

I have this:
Gnome 47.4 - Doesnt work
Gnome 46.0 - Works

@bannert1337
Copy link
Contributor Author

bannert1337 commented Feb 27, 2025

Not working:
Image

@crschnick
Copy link
Member

Yeah feel free to augment that list where it works and where it doesn't for any other systems you have. Also for KDE. The more information, the better they can fix it

@bannert1337
Copy link
Contributor Author

Not working:

OS: CachyOS x86_64
Host: 20XLS0KB02 (ThinkPad T14 Gen 2a)
Kernel: Linux 6.13.4-2-cachyos
DE: KDE Plasma 6.3.2
WM: KWin (Wayland)
WM Theme: Breeze
Theme: Breeze (Dark) [Qt], Breeze-Dark [GTK2], Breeze [GTK3]
Icons: breeze-dark [Qt], breeze-dark [GTK2/3/4]

@crschnick
Copy link
Member

I forwarded this to the JavaFX devs, let's see what happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants