Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading from json instead on from ink breaks the external function binding #1082

Open
DrAlta opened this issue Sep 26, 2024 · 2 comments
Open

Comments

@DrAlta
Copy link

DrAlta commented Sep 26, 2024

Describe the bug

the value return in a now some type of object, it can't be converted into a Value

Environment

  • OS: Win11
  • Node.js version: 22.0.0
  • RPG maker MV: 1.6.1
  • NW: 0.88.0
  • inkjs version: 2.2.2 and 2.3.0

Additional context

I've inherited the code base after the previous programmer left. and ink.js docs don't really documenting it more than saying, "It's a port of ink! you're an expert, right? in the original and in porting C# to js so you can figure it out."

@smwhr
Copy link
Collaborator

smwhr commented Sep 28, 2024

Can you provide a reproducible sample of code showing the problem ?

@DrAlta
Copy link
Author

DrAlta commented Oct 6, 2024

Sorry it took so long to get back to you, been crunching at work.

Here's the RPG maker MV plugin. I added the original version of the code I changed in a comment
It's just the build and construct method of the InkFactory class

NG_InkManager.zip

InkScene.setupScene("knot")

then does a loop call InkScene.next() until InkScene.isDone() is true

If I understood the code enough to make MRE I could probably fix it myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants