-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implementation in Keras #18
Comments
Thanks for the good questions. Just some quick answers:
Bonus answer: Yes. I haven't tried not masking the MCCs, but if you keep them you will probably get a bunch of "color checker" detectors, which clearly doesn't generalize to cases where there are no MCCs. Please let me know if you have more questions. |
I have finished implementing your model in Keras framework. Though, I made some adjustments, such as: using VGG16 instead of Squeezenet, dividing the images into patches and train on all those patches... After training for 20 epochs with about 2000 patches (from 200 images) and testing on 160 images, I have the following results:
It's surprising me that the median is higher than the one in your paper. Also, I noticed that your model (or at least your ideas on my Keras implementation) perform better with indoor scenes (when comparing with CNN from Bianco or Deep Specialized Net from Wu shi). |
Hello and thanks for the implementation! However, I'm also surprised that the median error is even higher than the mean error. It's interesting that our approach performs better on indoor scenes. To be honest I didn't draw this conclusion when doing this project. Thanks for letting me know. One explanation is that indoor scenes contain more noise (textureless walls, light bulbs, varying illumination etc.) with which our approach deals better. Your implementation looks good (though I'm not very experienced with Keras). Again, the suprising thing is the high median angular error. One thing we can do is to visualize the norm of estimations to see if the confidence values are reasonable. |
After reading you Supplementary Material (for the FC4 paper) and the function As I understand,
|
Thanks for the questions.
|
Btw, 2041x1359 is too large for FC4. I think in my code I downsample it by a factor of two. |
Hi! I've just started to learn Keras and I am really interested how this re-implementation looks like. @hienpham15 do you still have your source code? I would be really grateful if you could share it. |
Hi, since I'm trying to re-implement your code in Keras (python 3.6), I open this thread for some questions and advice.
Did you train your SqueezeNet from scratch or use the wieghts from the pretrained SqueezeNet model ?
When you perform the data augmentation:
This will change the original ground truth illumination wthout retaining the von Kries ratio, so my question is why? What's your intuition behind this?
Bonus question: Is it necessary to mask out the MCCs? I see no reason behind this also
The text was updated successfully, but these errors were encountered: