From 73a5dbfa75899d9794618874ec4cff2ea49de450 Mon Sep 17 00:00:00 2001
From: Yunus <yunus.rectangle951@silomails.com>
Date: Tue, 3 Dec 2024 13:34:34 +0700
Subject: [PATCH] Improve upload dialog to drawer

---
 assets/css/main.css                           | 13 +++
 components/AppFileUpload.vue                  | 83 +++++++++++--------
 components/InputFileUpload.vue                | 53 ++++++++++++
 components/Releases.vue                       | 26 ++----
 .../[appId]/releases/[detailArtifact].vue     | 15 ----
 .../api/artifacts/upload-artifact-url.post.ts |  4 +-
 6 files changed, 124 insertions(+), 70 deletions(-)
 create mode 100644 components/InputFileUpload.vue

diff --git a/assets/css/main.css b/assets/css/main.css
index 6815b8d..e767940 100644
--- a/assets/css/main.css
+++ b/assets/css/main.css
@@ -86,4 +86,17 @@ body {
 
 .appdark .bg-color {
     background: rgb(25, 25, 25);
+}
+
+.p-multiselect {
+    min-width: 17rem;
+}
+
+.p-multiselect-label {
+    display: flex;
+    flex-wrap: wrap;
+}
+
+.p-multiselect-token {
+    margin: 0.1rem;
 }
\ No newline at end of file
diff --git a/components/AppFileUpload.vue b/components/AppFileUpload.vue
index c122313..b0d7ef3 100644
--- a/components/AppFileUpload.vue
+++ b/components/AppFileUpload.vue
@@ -1,37 +1,48 @@
 <template>
-    <div class="flex flex-col gap-3" v-if="mimeTypeFromOsType">
-        <input class="p-2 border rounded-lg" ref="fileRef" type="file" :accept="mimeTypeFromOsType">
-        <div class="flex flex-col gap-2">
-            <label for="releasenotes">Release Notes</label>
-            <InputText id="releasenotes" v-model="releaseNotes" aria-describedby="releasenotes-help" />
+    <Drawer class="!w-[30rem]" position="right" header="Upload" v-model:visible="showUpload">
+        <div class="flex flex-col gap-3" v-if="mimeTypeFromOsType">
+            <div>
+                <InputFileUpload v-model="fileList" type="file" :accept="mimeTypeFromOsType" @change="checkFile" />
+            </div>
+            <div class="flex flex-col gap-2">
+                <label for="releasenotes">Release Notes</label>
+                <Textarea rows="4" id="releasenotes" v-model="releaseNotes" aria-describedby="releasenotes-help" />
+            </div>
+            <div class="flex flex-col gap-2">
+                <label for="releasenotes">Groups</label>
+                <MultiSelect v-model="selectedGroup" display="chip" :options="groups" optionLabel="name"
+                    placeholder="Select Groups" filter />
+            </div>
+            <Button class="self-end mt-4" :label="isPending ? 'Uploading...' : 'Upload'" @click="submit"
+                :loading="isPending" />
         </div>
-        <div class="flex flex-col gap-2">
-            <label for="releasenotes">Groups</label>
-            <MultiSelect v-model="selectedGroup" display="chip" :options="groups" optionLabel="name"
-                placeholder="Select Groups" filter />
-        </div>
-        <Button :label="isPending ? 'Uploading...' : 'Upload'" @click="submit" :loading="isPending" />
-    </div>
+    </Drawer>
 </template>
 
 <script setup lang="ts">
-import { UpdateGroupsRequest } from '~/server/api/update-artifact-groups.put';
+import { UpdateGroupsRequest } from '~/server/api/update-artifact-groups.put'
 
-const releaseNotes = ref<string | null>(null)
-const dialogRef = inject<any>('dialogRef');
-const osType = ref<OsType | null>(null)
-const prop = ref<any>(null)
-const orgName = ref<string>('')
-const appName = ref<string>('')
-prop.value = dialogRef.value.data.props
-osType.value = dialogRef.value.data.props.osType
-orgName.value = dialogRef.value.data.props.orgName
-appName.value = dialogRef.value.data.props.appName
+const showUpload = defineModel<boolean>()
+const props = defineProps<{
+    dataProps: any,
+}>()
+const emit = defineEmits(['onSuccess'])
 
-const groupName = computed(() => dialogRef.value.data.groupName)
+const releaseNotes = ref<string | null>(null)
+const osType = computed<OsType | null>(() => props.dataProps!.osType)
+const orgName = computed(() => props.dataProps!.orgName)
+const appName = computed(() => props.dataProps!.appName)
+const groupName = computed(() => props.dataProps.groupName)
 
 const mimeTypeFromOsType = computed(() => osType.value ? getMimeTypeFromosType(osType.value) : undefined)
-const fileRef = ref<HTMLInputElement | null>(null)
+const fileList = ref<FileList | undefined>()
+// const fileApkRef = ref<HTMLInputElement | null>(null)
+const showUploadFileApk = ref(false)
+const isFileAab = ref(false)
+function checkFile(event: Event) {
+    const input = event.target as HTMLInputElement
+    isFileAab.value = input.files?.item(0)?.name?.endsWith('.aab') || false
+}
 
 const { data: appGroups } = useFetch('/api/groups/list-groups', {
     query: {
@@ -52,8 +63,8 @@ watchEffect(() => {
 })
 
 const { mutateAsync, isPending } = useMutation({
-    mutationFn: async (file: File) => {
-        const { artifactId } = await onUpload(file, undefined)
+    mutationFn: async (param: { file: File, apkFile: File | undefined }) => {
+        const { artifactId } = await onUpload(param.file, param.apkFile)
         const groupIds = selectedGroup.value?.map(e => e.id) ?? []
         if (artifactId && groupIds && groupIds.length) {
             await $fetch('/api/update-artifact-groups', {
@@ -66,22 +77,24 @@ const { mutateAsync, isPending } = useMutation({
         }
     },
     onSuccess: () => {
-        if (fileRef.value) {
-            fileRef.value.value = ''
-            dialogRef.value.close({
-                success: true,
-            });
+        if (fileList.value) {
+            fileList.value = undefined
+            emit('onSuccess')
         }
     },
 })
 
 const submit = async () => {
-    const inputFile = fileRef.value as HTMLInputElement | null
-    const realFile = inputFile?.files && inputFile?.files.length ? inputFile.files[0] : undefined
+    const realFile = fileList.value?.length ? fileList.value[0] : undefined
     if (!realFile) {
         return
     }
-    mutateAsync(realFile)
+    // const inputApkFile = fileApkRef.value as HTMLInputElement | null
+    // const apkActualFile = inputApkFile?.files && inputApkFile?.files.length ? inputApkFile.files[0] : undefined
+    mutateAsync({
+        file: realFile,
+        apkFile: undefined,
+    })
 }
 
 const onUpload = async (file: File, apkFile: File | undefined) => {
diff --git a/components/InputFileUpload.vue b/components/InputFileUpload.vue
new file mode 100644
index 0000000..2cc24c7
--- /dev/null
+++ b/components/InputFileUpload.vue
@@ -0,0 +1,53 @@
+<template>
+    <AppCard @click="clickUpload" class="cursor-pointer !py-3">
+        <div class="flex flex-row items-center">
+            <div class="flex-1 flex flex-col">
+                <template v-if="modelFile">
+                    <span>{{ modelFile.name }}</span>
+                    <span class="text-sm">{{ formatBytes(modelFile.size) }}</span>
+                </template>
+                <span v-else>Click to upload here</span>
+            </div>
+            <Button v-if="modelFile" icon="pi pi-times" text @click="(e) => {
+                e.stopPropagation()
+                model = undefined
+            }" />
+            <Button v-else icon=" pi pi-upload" text />
+        </div>
+    </AppCard>
+    <input ref="fileRef" :modelValue="model" class="hidden" type="file" :accept="prop.accept" @change="(e) => {
+        onChange(e)
+    }">
+</template>
+
+<script setup lang="ts">
+import { formatBytes } from '#imports'
+
+defineOptions({
+    inheritAttrs: false,
+})
+
+const fileRef = ref<HTMLInputElement>()
+const model = defineModel<FileList | undefined>()
+watchEffect(() => {
+    if (!model.value && fileRef.value) {
+        fileRef.value.value = ''
+    }
+})
+const modelFile = computed(() => model.value && model.value.length ? model.value.item(0) : undefined)
+const prop = defineProps<{
+    accept?: string,
+}>()
+function onChange(event: Event) {
+    const inputEl = event.target as HTMLInputElement
+    model.value = inputEl?.files || undefined
+    emit('change', event)
+}
+const emit = defineEmits<{
+    (e: 'change', event: Event): void
+}>()
+
+function clickUpload() {
+    fileRef.value?.click()
+}
+</script>
diff --git a/components/Releases.vue b/components/Releases.vue
index 896bed0..cbad3ed 100644
--- a/components/Releases.vue
+++ b/components/Releases.vue
@@ -36,11 +36,16 @@
             </template>
         </DataTable>
     </div>
+    <AppFileUpload v-model="showUpload" :dataProps="props" @on-success="() => {
+        showUpload = false
+        refresh()
+    }" />
 </template>
 
 <script setup lang="ts">
 import AppFileUpload from './AppFileUpload.vue';
 import { DataTableRowClickEvent } from 'primevue/datatable';
+import { formatDate } from '#imports';
 
 const props = defineProps<{
     orgName: string,
@@ -69,29 +74,12 @@ const { data, refresh } = useFetch('/api/artifacts/list-artifacts', {
 })
 const list = computed(() => data.value)
 
-const dialog = useDialog();
-
+const showUpload = ref(false)
 const upload = () => {
     if (!props.osType) {
         return
     }
-
-    dialog.open(AppFileUpload, {
-        props: {
-            modal: true,
-            header: 'Upload',
-            closeOnEscape: false,
-        },
-        data: {
-            props,
-            groupName: props.groupName,
-        },
-        onClose: (o) => {
-            if (o?.data?.success) {
-                refresh()
-            }
-        }
-    })
+    showUpload.value = true
 }
 
 const selectRow = async (row: DataTableRowClickEvent) => {
diff --git a/pages/orgs/[orgName]/apps/[appId]/releases/[detailArtifact].vue b/pages/orgs/[orgName]/apps/[appId]/releases/[detailArtifact].vue
index 06f890a..ff94b05 100644
--- a/pages/orgs/[orgName]/apps/[appId]/releases/[detailArtifact].vue
+++ b/pages/orgs/[orgName]/apps/[appId]/releases/[detailArtifact].vue
@@ -54,21 +54,6 @@
     </div>
 </template>
 
-<style>
-.p-multiselect {
-    min-width: 17rem;
-}
-
-.p-multiselect-label {
-    display: flex;
-    flex-wrap: wrap;
-}
-
-.p-multiselect-token {
-    margin: 0.1rem;
-}
-</style>
-
 <script setup lang="ts">
 import { formatDate, formatBytes } from '#imports'
 import { UpdateGroupsRequest } from '~/server/api/update-artifact-groups.put';
diff --git a/server/api/artifacts/upload-artifact-url.post.ts b/server/api/artifacts/upload-artifact-url.post.ts
index 4aa0291..10aabc9 100644
--- a/server/api/artifacts/upload-artifact-url.post.ts
+++ b/server/api/artifacts/upload-artifact-url.post.ts
@@ -1,8 +1,9 @@
 import { findApiKey } from "./upload-artifact.post"
 
 export default defineEventHandler(async (event) => {
-    const { fileKey, appName, orgName, releaseNotes, packageMetadata, } = await readValidatedBody(event, z.object({
+    const { fileKey, apkFileKey, appName, orgName, releaseNotes, packageMetadata, } = await readValidatedBody(event, z.object({
         fileKey: z.string().max(128),
+        apkFileKey: z.string().max(128).nullish(),
         appName: z.string().trim().min(1).max(128),
         orgName: z.string().trim().min(1).max(128),
         releaseNotes: z.string().nullish(),
@@ -64,6 +65,7 @@ export default defineEventHandler(async (event) => {
         createdAt: now,
         updatedAt: now,
         fileObjectKey: fileKey,
+        fileObjectApkKey: apkFileKey,
         versionCode2: packageData?.versionCode?.toString()!,
         versionName2: packageData?.versionName!,
         appsId: appId,