Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Removing previously scheduled metrics collector" happens after every "Collected new external metric" #774

Open
kyledavelaar opened this issue Jan 10, 2025 · 0 comments · May be fixed by #785

Comments

@kyledavelaar
Copy link

Expected Behavior

Should the log "Removing previously scheduled metrics collector" happen every time kube-metrics-adapter logs "Collected new external metric"? It seems like it should not be removing the metrics collector each time?

Actual Behavior

"Removing previously scheduled metrics collector" happens after every "Collected new external metric"

Steps to Reproduce the Problem

  1. use external http collector which hits a custom metrics api. the metrics api returns a payload of { custom_metric: 90 } and the hpa is configured to scale based on that value. Note: the scaling is working for me.

Specifications

  • Version: Latest version of kube-metrics-adapter
  • Platform: Running Kubernetes 1.29 in Amazon EKS.
@mikkeloscar mikkeloscar linked a pull request Feb 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant