-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] h5py compat methods on Group #2128
[v3] h5py compat methods on Group #2128
Conversation
…, and require_gruops methods to group class
…nto feature/h5py-compat-group
…nto feature/h5py-compat-group
In general, big 👍 for the compatibility. cc: @clbarnes of https://github.com/clbarnes/h5py_like fame in case there are any lessons learned, etc. that we should take into account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to adding deprecation warnings to create_dataset and require_dataset (perhaps replacing the latter with require_array) if we want to phase out the h5py specific language.
+1 to this, ultimately we shouldn't use the term "dataset". But for short-term hdf5 compatibility this PR looks good.
I'm going to go ahead and merge this but happy to take feedback from @clbarnes here or in #1597. |
Nothing specific to say, just happy if h5py_like was of any use! Definitely agree on throwing PendingDeprecationWarnings whenever these short-term compatibility measures are used, otherwise you'll never be rid of them. |
This PR adds the h5py compat methods to the Zarr Group API from v2.
The plan described in #1583 was to remove these but after looking into it, a bit more, I came to the conclusion that
require_group
andrequire_dataset
are actually pretty useful. I'm open to adding deprecation warnings tocreate_dataset
andrequire_dataset
(perhaps replacing the latter withrequire_array
) if we want to phase out the h5py specific language.closes #1597
TODO: