Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13, drop Python 3.10 #2344

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

dstansby
Copy link
Contributor

As per SPEC 0 we can drop Python 3.10, and this also adds tests for Python 3.13. Fixes #2317

@dstansby dstansby added the V2 Affects the v2 branch label Oct 12, 2024
@jhamman
Copy link
Member

jhamman commented Oct 12, 2024

would you mind switching the base of this PR to the support/2.x branch?

@dstansby dstansby changed the base branch from main to support/v2 October 13, 2024 07:29
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm impressed things worked on 3.13 without any changes.

@jhamman jhamman merged commit ed94877 into zarr-developers:support/v2 Oct 15, 2024
6 checks passed
@dstansby dstansby deleted the py313 branch October 15, 2024 18:26
@joshmoore
Copy link
Member

A bit late to the party but perhaps more for future cases of applying SPEC 0, I'd vote for always bumping the minor version when dropping a version of Python, i.e. I would have been for this being 2.19.0. The primary reason is that if something else occurs (critical data loss issue, etc.) it gives us the chance to fix that bug without forcing developers to bump their Python version.

@dstansby
Copy link
Contributor Author

A bit late to the party but perhaps more for future cases of applying SPEC 0, I'd vote for always bumping the minor version when dropping a version of Python, i.e. I would have been for this being 2.19.0. The primary reason is that if something else occurs (critical data loss issue, etc.) it gives us the chance to fix that bug without forcing developers to bump their Python version.

👍 - might be worth adding a note to this effect to https://zarr.readthedocs.io/en/stable/contributing.html#api-compatibility so it doesn't get lost here?

@joshmoore
Copy link
Member

Very fair point. Thoughts on having a third type of compatibility since it stretches the definition of "API compatibility"? Alternatively, it could be a note there.

@dstansby dstansby mentioned this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 Affects the v2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants