-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.13, drop Python 3.10 #2344
Conversation
would you mind switching the base of this PR to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm impressed things worked on 3.13 without any changes.
A bit late to the party but perhaps more for future cases of applying SPEC 0, I'd vote for always bumping the minor version when dropping a version of Python, i.e. I would have been for this being 2.19.0. The primary reason is that if something else occurs (critical data loss issue, etc.) it gives us the chance to fix that bug without forcing developers to bump their Python version. |
👍 - might be worth adding a note to this effect to https://zarr.readthedocs.io/en/stable/contributing.html#api-compatibility so it doesn't get lost here? |
Very fair point. Thoughts on having a third type of compatibility since it stretches the definition of "API compatibility"? Alternatively, it could be a note there. |
As per SPEC 0 we can drop Python 3.10, and this also adds tests for Python 3.13. Fixes #2317