Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create new items via stdin to op command #172

Closed
zcutlip opened this issue Nov 15, 2023 · 2 comments
Closed

create new items via stdin to op command #172

zcutlip opened this issue Nov 15, 2023 · 2 comments
Assignees
@zcutlip
Labels
enhancement New feature or request

Comments

@zcutlip
Copy link
Owner

zcutlip commented Nov 15, 2023

Rather than write the new item template out to a temp file and then using --template, we should generate the template and send it to op._run() as input data.

This will let us get rid of the temp file management code.

We'll need to drop support for op versions that don't support receiving the template over stdin, which I believe is anything less than v2.2.2
@zcutlip zcutlip self-assigned this Nov 15, 2023
@zcutlip zcutlip added the enhancement New feature or request label Nov 15, 2023
@zcutlip
Copy link
Owner Author

zcutlip commented Nov 15, 2023

This will also help mitigate situations like #169 where op blocks indefinitely because it mistakenly thinks it should read data of stdin.

@zcutlip zcutlip mentioned this issue Nov 15, 2023
Closed
@zcutlip zcutlip changed the title Pipe new item template to op when creating items create new items via stdin to op command May 29, 2024
@zcutlip zcutlip mentioned this issue Aug 4, 2024
Merged
zcutlip added a commit that referenced this issue Aug 4, 2024
@zcutlip
Merge pull request #198 from zcutlip/dev/172-create-new-items-via-std…
14d3ea0 
…in-to-op-command

issue #172 create new items via stdin to op command
@zcutlip zcutlip mentioned this issue Aug 6, 2024
Merged
@zcutlip
Copy link
Owner Author

zcutlip commented Aug 7, 2024

complete as of #201

@zcutlip zcutlip closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zcutlip zcutlip

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zcutlip