Skip to content

Commit

Permalink
Add example compilation to CI (#24182)
Browse files Browse the repository at this point in the history
Stop #24165 from happening

Release Notes:

- N/A
  • Loading branch information
mikayla-maki authored Feb 4, 2025
1 parent 71f2cbe commit d400bde
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ jobs:
cargo check -p gpui --features "macos-blade"
cargo check -p workspace
cargo build -p remote_server
cargo check -p gpui --examples
script/check-rust-livekit-macos
# Since the macOS runners are stateful, so we need to remove the config file to prevent potential bug.
Expand Down Expand Up @@ -181,6 +182,7 @@ jobs:
run: |
cargo build -p zed
cargo check -p workspace
cargo check -p gpui --examples
# Even the Linux runner is not stateful, in theory there is no need to do this cleanup.
# But, to avoid potential issues in the future if we choose to use a stateful Linux runner and forget to add code
Expand Down
10 changes: 7 additions & 3 deletions crates/gpui/src/elements/img.rs
Original file line number Diff line number Diff line change
Expand Up @@ -353,11 +353,15 @@ impl Element for Img {
}
}
} else {
let parent_view_id = window.parent_view_id().unwrap();
let parent_view_id = window.parent_view_id();
let task = window.spawn(cx, |mut cx| async move {
cx.background_executor().timer(LOADING_DELAY).await;
cx.update(move |_, cx| {
cx.notify(parent_view_id);
cx.update(move |window, cx| {
if let Some(parent_view_id) = parent_view_id {
cx.notify(parent_view_id);
} else {
window.refresh();
}
})
.ok();
});
Expand Down

0 comments on commit d400bde

Please sign in to comment.