Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More seamless AI edit application #16913

Open
nickelser opened this issue Aug 26, 2024 · 6 comments
Open

More seamless AI edit application #16913

nickelser opened this issue Aug 26, 2024 · 6 comments
Labels
ai Improvement related to Assistant, Copilot, or other AI features assistant AI feedback for Assistant (inline or panel) editor Feedback for code editing, formatting, editor iterations, etc feature [core label]

Comments

@nickelser
Copy link

It seems that through the /workflow command I can enable a somewhat limited (limited in that it fails to apply about 80% of the time) system where I can directly apply edits from the assistant.

I'd rather not have to do a special command, and instead just take the patches that Claude gives me, which are always in the format of:

# path/to/file
class AddFooBar < ActiveRecord::Migration[7.2]
  def change
    ...

and Zed could figure out if it was a new file, or existing file (ideally matching by name since sometimes it gets the path wrong), and have a button to just apply the changes (sometimes after I've edited them, since I love that I can edit the assistant responses).

My workaround right now is I just navigate to the file, select all, inline assistant, and tell it to "apply the changes we discussed." This has the benefit of being able to describe changes to the assistant output right there (if I need to say, e.g., apply the patch but remove the logging you added), but ideally I would be able to do that in another way (or I could just give the feedback in the assistant panel and then apply).

@nickelser nickelser changed the title It seems that through the /workflow command I can enable a somewhat limited (limited in that it fails to apply about 80% of the time) system where I can directly apply edits from the assistant. More seamless AI edit application Aug 26, 2024
@JosephTLyons JosephTLyons added feature [core label] editor Feedback for code editing, formatting, editor iterations, etc ai Improvement related to Assistant, Copilot, or other AI features assistant AI feedback for Assistant (inline or panel) labels Aug 26, 2024
@nickelser
Copy link
Author

to fix your trouble try download this fix

how does github have spam this bad, what on earth

@iamnbutler
Copy link
Member

and Zed could figure out if it was a new file, or existing file (ideally matching by name since sometimes it gets the path wrong), and have a button to just apply the changes (sometimes after I've edited them, since I love that I can edit the assistant responses).

This is exactly what /workflow attempts to do. It is a harder problem than it seems on the surface, especially for multiple sequential edits.

We are working on improving it. Rust performs significantly better than other languages for performing workflow edits right now - we are working on improving it beyond that. Thanks for trying it!

@sagarspatil
Copy link

and Zed could figure out if it was a new file, or existing file (ideally matching by name since sometimes it gets the path wrong), and have a button to just apply the changes (sometimes after I've edited them, since I love that I can edit the assistant responses).

This is exactly what /workflow attempts to do. It is a harder problem than it seems on the surface, especially for multiple sequential edits.

We are working on improving it. Rust performs significantly better than other languages for performing workflow edits right now - we are working on improving it beyond that. Thanks for trying it!

@iamnbutler /workflow is broken for python.
Are you aware of this?
#16894

@github-staff github-staff deleted a comment from masooddahmedd Sep 10, 2024
@aguynamedben
Copy link

+1. I'm trying Zed for the first time and can't figure out how to get it to apply any type of diff the Assistant generates. I'm able to use the /file command but /workflow isn't autocompleting for me in Python or Rust.

image

@elidickinson
Copy link

The ‘/workflow’ command was removed. Apparently it was never intended for general release. There appears to be an experimental feature flag to enable a different way to apply changes from the AI assistant. See #19900 (comment)

@danielytics
Copy link

danielytics commented Feb 2, 2025

/workflow is still documented as existing here: https://zed.dev/docs/assistant/commands#workflow

This confused the hell out of me, until I searched the issues to see that it was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai Improvement related to Assistant, Copilot, or other AI features assistant AI feedback for Assistant (inline or panel) editor Feedback for code editing, formatting, editor iterations, etc feature [core label]
Projects
None yet
Development

No branches or pull requests

7 participants