Some system language servers only work when both binary path and arguments are set

[jansol]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

Looks like Zed fails to find taplo from PATH for whatever reason (other language servers are found there) and even manually specifying the binary path doesn't work. It only started working after I set the path manually and also added the ["lsp", "stdio"] arguments. The auto-downloaded binary seems to get those arguments correctly, which is weird. "ignore_system_version" does not work regardless of whether arguments are given manually or not.

Texlab (via the LaTeX extension) appears to have the same problem. One thing that both have in common is that they require some kind of command line argument in order to actually start the LSP process.

Zed Version and System Specs

Zed: v0.169.0 (Zed Dev 78d342d)
OS: Linux Wayland ubuntu 24.04
Memory: 31.3 GiB
Architecture: x86_64
GPU: Radeon Vega Frontier Edition (RADV VEGA10) || radv || Mesa 24.0.9-0ubuntu0.3

If applicable, add screenshots or screencasts of the incorrect state / behavior

No response

If applicable, attach your Zed.log file to this issue.

No response

[lnay]

Just saw this. I believe the behaviour about reading the "lsp.x.binary" settings was completely up to extensions (at least as of September last year).

If this hasn't changed, then the TOML extension doesn't seem to care about those settings:

zed/extensions/toml/src/toml.rs

Line 102 in 83141d0

fn language_server_command(

The LaTeX extension only reads those settings when "path" is set:
https://github.com/rzukic/zed-latex/blob/d13761f254e7392bf550b758b8af440dd7878291/src/latex.rs#L52
It also does not try to expand relative paths or files in PATH, but that could be added.

It could also make sense to still use "arguments" even when "path" is not set in order to easily start file logging without having to dig out the path of the automatically downloaded executable.

[maxdeviant]

@jansol This is something that needs to be fixed at the extension level.

It looks like the TOML extension did not check for taplo on the PATH and also did not respect the language server binary settings.

Here's a fix for the TOML extension: #25276

[maxdeviant]

I'm going to close this, as it is something that needs to be addressed on an extension-by-extension basis.