-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: Add support for doctest runnables #24806
rust: Add support for doctest runnables #24806
Conversation
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Thanks for your PR!
|
…ust_doc_test_task
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@osiewicz thanks for your review.
For this one I can't think of a good solution, because we wouldn't have |
We could try to attach runs to the code blocks and not the annotated items. To be fair I think the bigger hurdle is how to spawn a task for one specific doc test. |
Correct me if I'm wrong but with the current implementation it will run one specific doc test because we have the symbol name. Maybe you're talking about your solution (attach the runs to the code blocks). @osiewicz Could we create an issue as a follow up mentioning that module-level doc tests are not implemented yet ? That's already a good addition I think. What do you think ? |
Sounds good! Yeah, I was talking about a fully robust implementation and that we'd have to "reverse-engineer" rust doctests a bit to know what query to spawn the tests with. You've nerd-sniped me, I will try to improve it a bit in a follow-up PR. :) |
Talking about the way RA works @osiewicz , is it the plan to use the experimental |
We've considered using runnables from RA when we did an initial task implementation - I'm somewhat against it (at least as the only implementation of tests) as other languages don't usually provide similar experience. |
Screenshot:
I would be happy to add tests if you point me to the right place to do it please.
Release Notes: