windows: Fix recursive dir copy #25213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
Hi, thank you for your PR and for looking into this! After reviewing the issue, it seems that this is not exclusive to Windows; I was able to reproduce it on my Mac as well. The fix introduced by this PR appears to be more of a workaround rather than a fix. Please refer to #25317 for further details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24746
Release Notes:
Currently I have just add small check for windows to prevent that the user is not trying to paste the copied dir within the same dir creating an infinite amount of DIRs
Untitled.video.-.Made.with.Clipchamp.mp4