-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jump list support for Windows #25253
Conversation
We require contributors to sign our Contributor License Agreement, and we don't have @wangfu91 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Thank you very much for your PR. After a quick review, it seems that your PR does not address the singleton pattern. Currently, we only allow a single instance of Zed to run at a time, so in your PR, clicking the jumplist does not launch Zed. We already have another PR that addresses this issue by using a more recent API, which also handles the singleton pattern. Therefore, closing this PR. |
Why? This seems like an unnecessary limitation to me, and I'd like to understand the rationale behind this decision. |
That's not the case based on my testing (I'm testing with the latest code in
I see, the UWP JumpList API is indeed simpler. I'm creating this PR mainly because I need the ability to quickly open the recent projects in the right-click jump list, are you going to implement that in your PR #17352? |
It's disabled if you are using dev channel, you can modify this here: https://github.com/zed-industries/zed/blob/main/crates/zed/RELEASE_CHANNEL
We definitely will impl this in the near future, as a part of #24800. But I think not in PR #17352 |
This PR addresses issue #12068.
It adds support for Windows jump lists (taskbar icon right-click) for Zed. Please see the attached screenshot for reference:
To implement this, I had to reintroduce the
add_recent_documents
andclear_recent_documents
functions, which were previously removed from PR #9919.As this is my first PR for Zed and I'm not very familiar with the codebase, there might be more efficient ways to achieve this. I would greatly appreciate any feedback or suggestions.
Release Notes: