Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git_ui: Do not show commit message editor and open diff button with no changes #25522

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

git_ui: Do not show commit message editor and open diff button with no changes #25522

wants to merge 9 commits into from

Conversation

Angelk90
Copy link
Contributor

@Angelk90 Angelk90 commented Feb 24, 2025 •
edited
Loading

Before pr change file pr no change file
Screenshot 2025-02-25 alle 00 42 35 Screenshot 2025-02-25 alle 00 45 02 Screenshot 2025-02-25 alle 00 47 35
Screenshot 2025-02-25 alle 01 28 50 Screenshot 2025-02-25 alle 01 28 31

Release Notes:

  • if no file is modified do not show commit message field
  • if no file is modified do not show Open diff button
  • move most recent commit to bottom
  • show repository selector only when multiple repositories are available

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 24, 2025
@zed-industries-bot
Copy link

zed-industries-bot commented Feb 24, 2025 •
edited
Loading

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against daf98c7

@maxdeviant maxdeviant changed the title Git panel if there is no modified file do not show commit message field and Open diff button git_ui: Do not show commit message editor and open diff button with no changes Feb 25, 2025
@Angelk90
Copy link
Contributor Author

@iamnbutler : can you give me an opinion on these changes if they are good or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Angelk90 @zed-industries-bot