Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Upgrade to rustls v0.23.22" (#24197)" #24210

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Conversation

ConradIrwin
Copy link
Member

@ConradIrwin ConradIrwin commented Feb 4, 2025

try to reland rustls without breaking linux arm builders

See:

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 4, 2025
@ConradIrwin ConradIrwin added run-bundling Configures PR to run the bundle step and removed cla-signed The user has signed the Contributor License Agreement labels Feb 4, 2025
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 5, 2025
@ConradIrwin ConradIrwin merged commit 9114ca9 into main Feb 5, 2025
13 checks passed
@ConradIrwin ConradIrwin deleted the reland-rustls branch February 5, 2025 21:24
@ognevny
Copy link
Contributor

ognevny commented Feb 14, 2025

is it possible to use an alternative provider for rustls? I can't update Zed package for msys2 due to compile error with aws-lc-sys: aws/aws-lc-rs#696

@ConradIrwin
Copy link
Member Author

@ognevny It's not currently possible.

If was-lc-sys can fix the problem in the next few weeks we'd prefer to keep using just one crypto provider; but if they are unable to solve it, we would probably be ok with a compile time flag if you wanted to send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement run-bundling Configures PR to run the bundle step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants