Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

title_bar: Allow deafening audio without microphone permission #24761

Merged

Conversation

devzeth
Copy link
Member

@devzeth devzeth commented Feb 12, 2025

The deafen audio button wasn't visible in the titlebar unless you had the 'use microphone permission'. Meaning if I would join a call, and didn't receive permission to speak, I wouldn't be able to use the deafen audio button.

Now the button is directly visible when you join a call. So you can deafen the audio even if you didn't receive the mic permission.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 12, 2025
@maxdeviant maxdeviant changed the title titlebar: Allow deafen audio without microphone permission title_bar: Allow deafening audio without microphone permission Feb 14, 2025
@devzeth devzeth requested a review from ConradIrwin February 19, 2025 23:56
@devzeth devzeth closed this Feb 21, 2025
@devzeth devzeth force-pushed the deafen-audio-always-usable-in-call branch from 2a60c10 to 3e75a66 Compare February 21, 2025 21:35
@devzeth devzeth reopened this Feb 21, 2025
@devzeth devzeth assigned devzeth and ConradIrwin and unassigned devzeth Feb 21, 2025
@ConradIrwin ConradIrwin enabled auto-merge (squash) February 21, 2025 21:48
@devzeth devzeth removed the request for review from ConradIrwin February 21, 2025 21:53
@ConradIrwin ConradIrwin merged commit 7ff4009 into zed-industries:main Feb 21, 2025
13 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants