Eagerly load the active theme and icon theme #25368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds eager loading of the active theme and icon theme set in the user settings.
Previously for themes and icon themes that were provided by extensions, we would have to wait until extensions were loaded before we could apply the themes.
In some cases this could lead to a visible delay during which time the user would see the default themes, and then switch to their desired themes once extensions had loaded.
To avoid this, we now take a fast path of loading the active themes directly from the filesystem so that we can load them as soon as possible.
Closes #10173 and #25305.
Release Notes: