Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Accounts]: Wrong IDP selection error will not pop-up again a second time #2168

Open
shrunyan opened this issue Nov 30, 2023 · 4 comments
Assignees

Comments

@shrunyan
Copy link
Contributor

Issue:
If a user selects the wrong SSO IDP when loging in the flow finishes and an error pop occurs. If the user selects the wrong SSO IDP any additional times the error pop-up is no longer shown.

Expectation:
The error pop-up must occur everytime a user selects the wrong IDP for the registered email

@darwin808
Copy link
Contributor

darwin808 commented Dec 1, 2023

@agalin920

this happen both manager and website

Screen.Recording.2023-12-01.at.11.37.51.AM.mov
Screen.Recording.2023-12-01.at.11.37.23.AM.mov

@mattezra
Copy link

mattezra commented Jan 8, 2024

@shrunyan

This might be an issue in the login component in the material repo.

@agalin920 @theofficialnar please confirm.

@finnar-bin
Copy link
Contributor

finnar-bin commented Jan 12, 2024

@mattezra after checking this out on manager-ui, the ssoError does not get cleared when the error alert message is closed. So when the same error message happens on a failed login attempt, the error alert component no longer shows up, since these lines right here won't rerun unless ssoError is either cleared or is a different value.

As for the website login, I don't know how the error is being shown/hidden though so I can't provide any input on that.

I created a bug ticket on manager-ui so it can be addressed there as well.

@agalin920
Copy link
Contributor

@darwin808 zesty-io/material#84 PR is up for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants