Fix Issues in webservice quickstart #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zio-quickstart-restful-webservice does not work as expected as mentioned in the documentation. https://zio.dev/guides/quickstarts/restful-webservice/
Issue 1:
For Download Routes, it's not returning the correctly formed output. Apparently, the
fromStream
method uses a binary encoder, andfromStreamChunked
does not.Expected output:
Actual Output
Issue 2:
For Greetings Routes, the logic of the routes is not correct. The
/greet
route does not return the correct response.Expected Output
Actual Output
Issue 3:
Moreover, the logic for handling multiple names is also incorrect.
Expected Output
Actual Output