diff --git a/prover/src/keccak_sponge/keccak_sponge_stark.rs b/prover/src/keccak_sponge/keccak_sponge_stark.rs index 0066346c..a2fe4325 100644 --- a/prover/src/keccak_sponge/keccak_sponge_stark.rs +++ b/prover/src/keccak_sponge/keccak_sponge_stark.rs @@ -221,7 +221,7 @@ pub struct KeccakSpongeStark { impl, const D: usize> KeccakSpongeStark { pub(crate) fn generate_trace( &self, - operations: &Vec, + operations: Vec, min_rows: usize, ) -> Vec> { // Generate the witness row-wise. @@ -232,7 +232,7 @@ impl, const D: usize> KeccakSpongeStark { fn generate_trace_rows( &self, - operations: &Vec, + operations: Vec, min_rows: usize, ) -> Vec<[F; NUM_KECCAK_SPONGE_COLUMNS]> { let base_len: usize = operations @@ -240,7 +240,7 @@ impl, const D: usize> KeccakSpongeStark { .map(|op| op.input.len() / KECCAK_RATE_BYTES + 1) .sum(); let mut rows = Vec::with_capacity(base_len.max(min_rows).next_power_of_two()); - for op in operations.iter() { + for op in operations { rows.extend(self.generate_rows_for_op(op)); } let padded_rows = rows.len().max(min_rows).next_power_of_two(); @@ -250,7 +250,7 @@ impl, const D: usize> KeccakSpongeStark { rows } - fn generate_rows_for_op(&self, op: &KeccakSpongeOp) -> Vec<[F; NUM_KECCAK_SPONGE_COLUMNS]> { + fn generate_rows_for_op(&self, op: KeccakSpongeOp) -> Vec<[F; NUM_KECCAK_SPONGE_COLUMNS]> { let mut rows = Vec::with_capacity(op.input.len() / KECCAK_RATE_BYTES + 1); let mut sponge_state = [0u32; KECCAK_WIDTH_U32S]; diff --git a/prover/src/witness/traces.rs b/prover/src/witness/traces.rs index 8f45775e..89df3a9d 100644 --- a/prover/src/witness/traces.rs +++ b/prover/src/witness/traces.rs @@ -223,7 +223,7 @@ impl Traces { .generate_trace(&keccak_inputs, min_rows), || keccak_sponge_trace = all_stark .keccak_sponge_stark - .generate_trace(&keccak_sponge_ops, min_rows), + .generate_trace(keccak_sponge_ops, min_rows), || logic_trace = all_stark.logic_stark.generate_trace(&logic_ops, min_rows), ) );