Metal building pipeline enhancement #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is converted to draft due to iOS pipeline haven't been implemented yet. |
yaroslavyaroslav
force-pushed
the
metal-build-pipeline
branch
from
902d9dd to
0a68ac4
Compare
|
@moven0831 I haven't removed all.metal file yet, to avoid unnecessary conflicts with your pending PR #13 But it's the matter of changing a single function in the build current pipeline, so it won't take any long to do it afterwards. PR is ready for review |
1. Metal shaders for macOS compile with `build.rs` 2. `metallib` stored within std out dir rather than in the git repo under hardcoded path. 3. Prebuilt library and script deleted. 4. `build.rs` handles conditional debug symbols injection into metal lib by setting `[profile.release]\n debug = true` in `Cargo.toml`
yaroslavyaroslav
force-pushed
the
metal-build-pipeline
branch
from
0a68ac4 to
eeaf13a
Compare
moven0831
approved these changes
Nov 30, 2024
Comment on lines
+11
to
+14
| // List your Metal shaders here. | ||
| let shaders = vec!["all.metal"]; | ||
|
|
||
| let shaders_to_check = vec!["all.metal", "msm.h.metal"]; |
There was a problem hiding this comment.
will replace the all.metal with refactored shaders to be compiled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.rsmetallibstored within std out dir rather than in the git repo under hardcoded path.build.rshandles conditional debug symbols injection into metal lib by setting[profile.release]\n debug = trueinCargo.toml