Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): temporary commented precomputed msm part for the fix of msm correctness #24

Merged
merged 2 commits into from
Dec 22, 2024
Merged

fix(ci): temporary commented precomputed msm part for the fix of msm correctness #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaf92ba
chore: comment precomputed msm for now until it's been fixed
moven0831 Dec 22, 2024
153f788
chore: update GitHub Actions workflow to run tests in release mode
moven0831 Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ jobs:
- name: Run GPU Benchmarks tests
run: |
cd mopro-msm
cargo test test_msm_correctness -- --nocapture
cargo test --release test_msm_correctness -- --nocapture
3 changes: 2 additions & 1 deletion mopro-msm/src/msm/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ pub mod arkworks_pippenger;
pub mod bucket_wise_msm;
pub mod metal;
pub mod metal_msm;
pub mod precompute_msm;
// TODO: fix(precompute_msm): the correctness test will fail occasionally
// pub mod precompute_msm;
pub mod utils;

// Commeted since the trapdoortech_zprize_msm is not compatible with BN254 curve
Expand Down
Loading