Feat/cuzk/bucket point reduction #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in Metal - Add Barrett reduction implementation in Metal shader - Introduce new Metal shader types for extra-wide BigInt operations - Update shader constants to support Barrett reduction - Add test cases for Barrett reduction and field multiplication - Modify field reduction logic to use carry-based approach
- Implement Metal kernel for field multiplication - Update test to verify Montgomery form transformation - Simplify field multiplication test logic - Validate result using Montgomery form conversion
Feat/metal/cuzk/barrett_reduction
…/gpu-acceleration into feat/cuzk/bucket_point_reduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce bpr (parallel) Bucket point redution algorithm in gpu.
New Utility Functions:
bpr.metal, with 2 kernels:bpr_stage_1andbpr_stage_2.Refactoring and Enhancements:
jacobian_add_2007_bl) to handle special cases where one of the points is zero or both points are equal (mopro-msm/src/msm/metal_msm/shader/curve/jacobian.metal). [1] [2]jacobian_dbl_2009_lfunction to the top of the file and added it to thejacobian_add_2007_blfunction to handle doubling when points are equal (mopro-msm/src/msm/metal_msm/shader/curve/jacobian.metal). [1] [2]New Functions:
jacobian_scalar_mulfunction to perform scalar multiplication on Jacobian points (mopro-msm/src/msm/metal_msm/shader/curve/jacobian.metal).runfor scalar multiplication injacobian_scalar_mul.metal(mopro-msm/src/msm/metal_msm/shader/curve/jacobian_scalar_mul.metal).Tests:
bpr_stage_1test in rust side (mopro-msm/src/msm/metal_msm/shader/cuzk/bpr.rs)bpr_stage_2test in rust side.TODOs
bpr_stage_1is correct.bpr_stage_2is correct.