Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TD: pnpm build may display TypeErrors during webpack #3298

Open
zFernand0 opened this issue Nov 6, 2024 · 1 comment
Open

TD: pnpm build may display TypeErrors during webpack #3298

zFernand0 opened this issue Nov 6, 2024 · 1 comment
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases Technical Debt Includes Architecture, Code, Testing, Automation debt

Comments

@zFernand0
Copy link
Member

Describe the bug

During our builds, you may find the following entry:

  • TypeError: Cannot read properties of undefined (reading 'includes')

This likely happens due to an incompatibility between the TS version and one of the webpack plug-ins that we use

To Reproduce

Check out the CI lopgs

Expected behavior

No type error 😋

Stack-trace

Exception has occurred: TypeError: Cannot read properties of undefined (reading 'includes')
  at /Users/USER/gh/zowe/ze/node_modules/.pnpm/fork-ts-checker-webpack-plugin@9.0.2_typescript@5.6.3_webpack@5.96.1/node_modules/fork-ts-checker-webpack-plugin/lib/typescript/worker/lib/system.js:203:48
    at Array.some (<anonymous>)
    at isArtifact (/Users/USER/gh/zowe/ze/node_modules/.pnpm/fork-ts-checker-webpack-plugin@9.0.2_typescript@5.6.3_webpack@5.96.1/node_modules/fork-ts-checker-webpack-plugin/lib/typescript/worker/lib/system.js:203:29)
    at getReadFileSystem (/Users/USER/gh/zowe/ze/node_modules/.pnpm/fork-ts-checker-webpack-plugin@9.0.2_typescript@5.6.3_webpack@5.96.1/node_modules/fork-ts-checker-webpack-plugin/lib/typescript/worker/lib/system.js:208:66)
    at Object.getModifiedTime (/Users/USER/gh/zowe/ze/node_modules/.pnpm/fork-ts-checker-webpack-plugin@9.0.2_typescript@5.6.3_webpack@5.96.1/node_modules/fork-ts-checker-webpack-plugin/lib/typescript/worker/lib/system.js:75:23)
    at Object.getModifiedTime (/Users/USER/gh/zowe/ze/node_modules/.pnpm/fork-ts-checker-webpack-plugin@9.0.2_typescript@5.6.3_webpack@5.96.1/node_modules/fork-ts-checker-webpack-plugin/lib/typescript/worker/lib/host/watch-solution-builder-host.js:31:36)
    at getModifiedTime (/Users/USER/gh/zowe/ze/node_modules/.pnpm/typescript@5.6.3/node_modules/typescript/lib/typescript.js:7293:15)
    at getUpToDateStatusWorker (/Users/USER/gh/zowe/ze/node_modules/.pnpm/typescript@5.6.3/node_modules/typescript/lib/typescript.js:133378:102)
    at getUpToDateStatus (/Users/USER/gh/zowe/ze/node_modules/.pnpm/typescript@5.6.3/node_modules/typescript/lib/typescript.js:133587:18)
    at getNextInvalidatedProjectCreateInfo (/Users/USER/gh/zowe/ze/node_modules/.pnpm/typescript@5.6.3/node_modules/typescript/lib/typescript.js:133169:20)

Additional context

Source: https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/blob/main/src/typescript/worker/lib/system.ts#L286

@zFernand0 zFernand0 added bug Something isn't working Technical Debt Includes Architecture, Code, Testing, Automation debt priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases labels Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@zowe-robot zowe-robot moved this from New Issues to Low Priority in Zowe Explorer for VS Code Nov 6, 2024
@zFernand0 zFernand0 moved this from Low Priority to New Issues in Zowe Explorer for VS Code Nov 6, 2024
@JTonda JTonda moved this from New Issues to Low Priority in Zowe Explorer for VS Code Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases Technical Debt Includes Architecture, Code, Testing, Automation debt
Projects
Status: Low Priority
Development

No branches or pull requests

1 participant