fix: Only show "No configs detected" prompt if ZE opened #3281

traeok · 2024-10-28T13:05:36Z

Proposed changes

Fixes #3280

Release Notes

Milestone: 3.0.3

Changelog:

Fixed issue where Zowe Explorer would present the "No configs detected" notification before it was used in a workspace without a Zowe config. #3280

Types of changes

Bug fix (non-breaking change which fixes an issue)
Enhancement (non-breaking change which adds or improves functionality)
Breaking change (a change that would cause existing functionality to not work as expected)
Documentation (Markdown, README updates)
Other (please specify above in "Proposed changes" section)

Checklist

General

I have read the CONTRIBUTOR GUIDANCE wiki
All PR dependencies have been merged and published (if applicable)
A GIF or screenshot is included in the PR for visual changes
The pre-publish command has been executed:
- v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
- v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

There is coverage for the code that I have added
I have added new test cases and they are passing
I have manually tested the changes

Deployment

I have added developer documentation (if applicable)
Documentation should be added to Zowe Docs
- If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
- Otherwise, please check with the rest of the squad about any needed documentation before merging.
These changes may need ported to the appropriate branches (list here):

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

github-actions · 2024-10-28T13:16:18Z

📅 Suggested merge-by date: 11/11/2024

codecov · 2024-10-28T13:18:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (7cccbcf) to head (287afe6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3281      +/-   ##
==========================================
- Coverage   93.05%   93.05%   -0.01%     
==========================================
  Files         114      114              
  Lines       11798    11806       +8     
  Branches     2546     2548       +2     
==========================================
+ Hits        10979    10986       +7     
- Misses        817      818       +1     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

zFernand0

LGTM! 😋

Left a quick request, and please feel free to dismiss my requested-changes if you believe it doesn't make much sense for this fix 😋

packages/zowe-explorer/src/trees/dataset/DatasetInit.ts

packages/zowe-explorer/src/utils/ProfilesUtils.ts

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

zFernand0

LGTM! 😋

t1m0thyj

LGTM, thanks @traeok!

t1m0thyj · 2024-10-30T20:31:57Z

packages/zowe-explorer/src/utils/ProfilesUtils.ts

@@ -28,6 +28,7 @@ export enum ProfilesConvertStatus {

 export class ProfilesUtils {
    public static PROFILE_SECURITY: string | boolean = Constants.ZOWE_CLI_SCM;
+    private static noConfigDialogShown: boolean = false;


Should we rename this variable so it doesn't start with the word no? Please feel free to ignore, I'm definitely being picky but this was a bit hard to read because it seemed like a double negative 😋

Suggested change

private static noConfigDialogShown: boolean = false;

private static createConfigDialogShown: boolean = false;

Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>

JillieBeanSim

LGTM! thanks for this fix @traeok ❤️

zFernand0

LGTM as-is 😋
Up to y'all if we should wait for this final comment to be addressed:

fix: Only show "No configs detected" prompt if ZE opened #3281 (comment)

* fix: show 'No config detected' prompt once when ZE opened Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update ZE changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * resolve failing tests Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: move event into static fn, add coverage Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * patch coverage for ProfilesUtils.promptUserWithNoConfigs Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * move variable definition Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Co-authored-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

* DatasetFSprovider fetchDataset() - fix behavior with non-existent datasets and members (#3255) * Fix PDS members in fetchDataset Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * Update DatasetFSProvider.unit.test.ts Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * Update CHANGELOG.md Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * Merge branch 'main' into datasetfsprovider-remote-lookup-fix Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * move changelog update Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * improve logic Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * add ? after checking dsorg Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * do not fetch attributes for members Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> --------- Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * fix: use `vscode.workspace.fs` for `delete` and `rename` (#3261) * fix: use vscode.workspace.fs to rename URIs Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update ZE changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * update mocks, remaining use of delete/rename Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * Fix: To resolve error message upon switching the authentication methods (#3275) * To handle missing args in basicAuthClearSecureArray Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To handle missing args in tokenAuthClearSecureArray Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To add unit test case for missing arg's in basicAuthClearSecureArray Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To add unit test case for missing arg's in tokenAuthClearSecureArray Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To run pre-publish command Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To update changelog Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To modify tokenAuthClearSecureArray() function Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To add additional test cases for tokenAuthClearSecureArray() Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> --------- Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * fix: "Show Config" button in error dialog does not work during initialization (#3274) * fix: check if profileInfo is nullish during v1 migration Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update ZE changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: integration test for broken config Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * add unit test for nullish profileinfo Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix transient failures in UpdateCredentials scenario Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * remove extra join import in wdio conf Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * make integration test more reliable Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * move getprofileinfo call into try/catch during profiles init Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test: open notification center to check for dialog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * add license header to test; add another null check Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * add typedoc to ProfilesUtils.getProfileInfo Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * setupDefaultCredentialManager: log err msgs, update typedoc Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test: promptUserWithNoConfigs, nullish profileInfo case Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor typedoc for setupDefaultCredentialManager Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix(ds): Call remoteLookupForResource when entry doesn't exist locally (#3268) Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Co-authored-by: Billie Simmons <BillieJean.Simmons@ibm.com> * fix: Only show "No configs detected" prompt if ZE opened (#3281) * fix: show 'No config detected' prompt once when ZE opened Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update ZE changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * resolve failing tests Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: move event into static fn, add coverage Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * patch coverage for ProfilesUtils.promptUserWithNoConfigs Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * move variable definition Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Co-authored-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix(v3): Pass `responseTimeout` in z/OSMF MVS and USS API calls (#3292) * fix: pass responseTimeout to API functions Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: remove fallback for spreading newOptions Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: use optional chaining; work on resolving tests Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: pass profile props to tests, fix types Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: resolve failing cases in ZE Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update changelog entry for ZE API Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: remove fallback for spreading undefined options Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: add missing functions to MvsApi test list Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * run package Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * chore: remediation commit Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Third-Party DCO Remediation Commit for benjamin-t-santos <115251181+benjamin-t-santos@users.noreply.github.com> On behalf of benjamin-t-santos <115251181+benjamin-t-santos@users.noreply.github.com>, I, Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 8957a64 Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Third-Party DCO Remediation Commit for SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> On behalf of SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com>, I, Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 86a82f6 Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * DatasetFSProvider.readFile() makes at most one API call (#3279) * fix(ds): Call remoteLookupForResource when entry doesn't exist locally Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * readFile() uses one MVS API call Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * update unit tests, fix logic of calls Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * fix lint error Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * Update CHANGELOG.md Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> Signed-off-by: benjamin-t-santos <115251181+benjamin-t-santos@users.noreply.github.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Change default credentials manager check and not-found dialog (#3297) * updates to webpack and package.json for dev mode Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Remove endless startup loop when default CM cannot be loaded Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Initial set of test updates Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Merge branch 'main' into change-credentials-manager-check Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Convenience launch to only run currently open test Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Fixed ProfileUtils tests Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Clean up package files Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Updated changelog Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Reworded info message Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Update CHANGELOG.md Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * Added detail to info message Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Updated resource files Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> --------- Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix(3.0.3): Prompt in editor for 401 error, fix profile propagation (#3318) * fix: profile change propagation, prompt on auth error Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: profile propagation, tree node cases Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: changelogs Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test(jobs): add patch coverage Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: AuthUtils.promptForAuthError Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: UssFSProvider.fetchFileAtUri Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: reset wasAccessed flag if ImperativeError caught Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: resolve failing USS tests Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix failing jobs test Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix(ftp): Generate member name if missing in `putContents` (#3313) * fix(ftp): Generate member name if missing in putContents Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: add entry to FTP changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: remove unused isAbsolutePath import Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: undo updates to l10n since no strings were changed Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests(ftp): PDS upload case, clean up PS upload test Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: Billie Simmons <BillieJean.Simmons@ibm.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * run prepublish Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Fix infinite loop when fetching USS resources with stat() (#3321) * remove query when looking up parent Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * remove leftover comment Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * Update CHANGELOG.md Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> --------- Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * run prepublish Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Fix port of #3321 for 3.0.3 release Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> --------- Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: benjamin-t-santos <115251181+benjamin-t-santos@users.noreply.github.com> Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> Co-authored-by: benjamin-t-santos <115251181+benjamin-t-santos@users.noreply.github.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com>

@awharn

* DatasetFSprovider fetchDataset() - fix behavior with non-existent datasets and members (#3255) * Fix PDS members in fetchDataset Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * Update DatasetFSProvider.unit.test.ts Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * Update CHANGELOG.md Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * Merge branch 'main' into datasetfsprovider-remote-lookup-fix Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * move changelog update Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * improve logic Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * add ? after checking dsorg Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * do not fetch attributes for members Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> --------- Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * fix: use `vscode.workspace.fs` for `delete` and `rename` (#3261) * fix: use vscode.workspace.fs to rename URIs Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update ZE changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * update mocks, remaining use of delete/rename Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * Fix: To resolve error message upon switching the authentication methods (#3275) * To handle missing args in basicAuthClearSecureArray Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To handle missing args in tokenAuthClearSecureArray Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To add unit test case for missing arg's in basicAuthClearSecureArray Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To add unit test case for missing arg's in tokenAuthClearSecureArray Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To run pre-publish command Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To update changelog Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To modify tokenAuthClearSecureArray() function Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * To add additional test cases for tokenAuthClearSecureArray() Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> --------- Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> * fix: "Show Config" button in error dialog does not work during initialization (#3274) * fix: check if profileInfo is nullish during v1 migration Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update ZE changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: integration test for broken config Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * add unit test for nullish profileinfo Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix transient failures in UpdateCredentials scenario Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * remove extra join import in wdio conf Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * make integration test more reliable Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * move getprofileinfo call into try/catch during profiles init Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test: open notification center to check for dialog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * add license header to test; add another null check Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * add typedoc to ProfilesUtils.getProfileInfo Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * setupDefaultCredentialManager: log err msgs, update typedoc Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * test: promptUserWithNoConfigs, nullish profileInfo case Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor typedoc for setupDefaultCredentialManager Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix(ds): Call remoteLookupForResource when entry doesn't exist locally (#3268) Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Co-authored-by: Billie Simmons <BillieJean.Simmons@ibm.com> * fix: Only show "No configs detected" prompt if ZE opened (#3281) * fix: show 'No config detected' prompt once when ZE opened Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update ZE changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * resolve failing tests Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: move event into static fn, add coverage Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * update changelog Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * patch coverage for ProfilesUtils.promptUserWithNoConfigs Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * move variable definition Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Co-authored-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * fix(v3): Pass `responseTimeout` in z/OSMF MVS and USS API calls (#3292) * fix: pass responseTimeout to API functions Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: remove fallback for spreading newOptions Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: use optional chaining; work on resolving tests Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: pass profile props to tests, fix types Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * tests: resolve failing cases in ZE Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * chore: update changelog entry for ZE API Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * refactor: remove fallback for spreading undefined options Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * fix: add missing functions to MvsApi test list Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * run package Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * chore: remediation commit Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Third-Party DCO Remediation Commit for benjamin-t-santos <115251181+benjamin-t-santos@users.noreply.github.com> On behalf of benjamin-t-santos <115251181+benjamin-t-santos@users.noreply.github.com>, I, Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 8957a64 Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Third-Party DCO Remediation Commit for SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> On behalf of SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com>, I, Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 86a82f6 Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * DatasetFSProvider.readFile() makes at most one API call (#3279) * fix(ds): Call remoteLookupForResource when entry doesn't exist locally Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> * readFile() uses one MVS API call Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * update unit tests, fix logic of calls Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * fix lint error Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> * Update CHANGELOG.md Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> --------- Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> Signed-off-by: benjamin-t-santos <115251181+benjamin-t-santos@users.noreply.github.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Change default credentials manager check and not-found dialog (#3297) * updates to webpack and package.json for dev mode Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * Remove endless startup loop when default CM cannot be loaded Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Initial set of test updates Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Merge branch 'main' into change-credentials-manager-check Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Convenience launch to only run currently open test Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Fixed ProfileUtils tests Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Clean up package files Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Updated changelog Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Reworded info message Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Update CHANGELOG.md Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * Added detail to info message Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> * Updated resource files Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> --------- Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * prepare lerna and changelogs Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> * review: address PR feedback Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> * audit: fix audit issue (thanks @awharn) Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> --------- Signed-off-by: Benjamin Santos <benjamin.santos@ibm.com> Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com> Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com> Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: benjamin-t-santos <115251181+benjamin-t-santos@users.noreply.github.com> Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com> Co-authored-by: benjamin-t-santos <115251181+benjamin-t-santos@users.noreply.github.com> Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Co-authored-by: SanthoshiBoyina1 <142206957+SanthoshiBoyina1@users.noreply.github.com> Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Co-authored-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>

traeok added 2 commits October 28, 2024 09:04

fix: show 'No config detected' prompt once when ZE opened

44daa32

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

chore: update ZE changelog

533bd66

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

pull-request-size bot added the size/S label Oct 28, 2024

github-actions bot assigned traeok Oct 28, 2024

traeok linked an issue Oct 28, 2024 that may be closed by this pull request

Zowe Explorer Prompts Credentials for non z/OS Projects #3280

Closed

traeok added 2 commits October 28, 2024 09:13

resolve failing tests

4b80e38

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

Merge branch 'main' into fix/no-cfgs-prompt

9e108cf

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

traeok marked this pull request as ready for review October 28, 2024 13:16

refactor: move event into static fn, add coverage

e06415d

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

pull-request-size bot added size/M and removed size/S labels Oct 28, 2024

traeok requested review from t1m0thyj, zFernand0, JillieBeanSim, awharn, rudyflores, anaxceron, adam-wolfe, SanthoshiBoyina1 and likhithanimma1 October 28, 2024 13:56

traeok added 2 commits October 28, 2024 09:59

update changelog

f1e4fe3

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

patch coverage for ProfilesUtils.promptUserWithNoConfigs

41ed661

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

zFernand0 requested changes Oct 28, 2024

View reviewed changes

packages/zowe-explorer/src/trees/dataset/DatasetInit.ts Show resolved Hide resolved

t1m0thyj reviewed Oct 28, 2024

View reviewed changes

packages/zowe-explorer/src/utils/ProfilesUtils.ts Outdated Show resolved Hide resolved

move variable definition

dcf3cb2

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

traeok requested review from t1m0thyj and zFernand0 October 28, 2024 14:17

zFernand0 previously approved these changes Oct 28, 2024

View reviewed changes

anaxceron previously approved these changes Oct 29, 2024

View reviewed changes

Merge branch 'main' into fix/no-cfgs-prompt

648ed3a

t1m0thyj previously approved these changes Oct 30, 2024

View reviewed changes

Merge branch 'main' into fix/no-cfgs-prompt

28f5043

Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>

JillieBeanSim dismissed stale reviews from t1m0thyj, anaxceron, and zFernand0 via 28f5043 October 31, 2024 13:05

JillieBeanSim requested review from t1m0thyj, zFernand0 and anaxceron October 31, 2024 13:05

JillieBeanSim approved these changes Oct 31, 2024

View reviewed changes

JillieBeanSim added the bug Something isn't working label Oct 31, 2024

Merge branch 'main' into fix/no-cfgs-prompt

287afe6

zFernand0 approved these changes Oct 31, 2024

View reviewed changes

JillieBeanSim merged commit dbce388 into main Oct 31, 2024
32 checks passed

JillieBeanSim deleted the fix/no-cfgs-prompt branch October 31, 2024 14:36

JillieBeanSim mentioned this pull request Nov 6, 2024

v3.0.3 Release Plan #3250

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Only show "No configs detected" prompt if ZE opened #3281

fix: Only show "No configs detected" prompt if ZE opened #3281

traeok commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024

codecov bot commented Oct 28, 2024 •

edited

Loading

zFernand0 left a comment

zFernand0 left a comment

t1m0thyj left a comment

t1m0thyj Oct 30, 2024

JillieBeanSim left a comment

zFernand0 left a comment

	private static noConfigDialogShown: boolean = false;
	private static createConfigDialogShown: boolean = false;

fix: Only show "No configs detected" prompt if ZE opened #3281

fix: Only show "No configs detected" prompt if ZE opened #3281

Conversation

traeok commented Oct 28, 2024 • edited Loading

Proposed changes

Release Notes

Types of changes

Checklist

github-actions bot commented Oct 28, 2024

codecov bot commented Oct 28, 2024 • edited Loading

Codecov Report

zFernand0 left a comment

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

t1m0thyj left a comment

Choose a reason for hiding this comment

t1m0thyj Oct 30, 2024

Choose a reason for hiding this comment

JillieBeanSim left a comment

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

traeok commented Oct 28, 2024 •

edited

Loading

codecov bot commented Oct 28, 2024 •

edited

Loading