add metric for tx count in block

0glabs · Dec 25, 2024 · 78a74bf · 78a74bf
1 parent efac775
commit 78a74bf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/blockchain/metrics.go b/blockchain/metrics.go
@@ -9,6 +9,9 @@ const (
 	blockHeightBehindPattern   = "monitor/blockchain/block/height/behind/%v"
 	blockHeightUnhealthPattern = "monitor/blockchain/block/height/unhealth/%v"
 
+	// count of tx in block
+	blockTxCountPattern = "monitor/blockchain/block/tx/count"
+
 	// chain
 	chainForkPattern = "monitor/blockchain/fork/%v"
 	// ethermint rpc

diff --git a/blockchain/serve.go b/blockchain/serve.go
@@ -1,6 +1,7 @@
 package blockchain
 
 import (
+	"fmt"
 	"net/url"
 	"sync"
 	"time"
@@ -69,6 +70,8 @@ func createMetricsForChain() {
 
 	metrics.GetOrRegisterGauge(failedTxCountUnhealthPattern).Update(0)
 	metrics.GetOrRegisterHistogram(failedTxCountPattern).Update(0)
+
+	metrics.GetOrRegisterHistogram(blockTxCountPattern).Update(0)
 }
 
 func monitorOnce(config *Config, nodes []*Node, validators []*Validator, mempool *Mempool) {
@@ -131,7 +134,12 @@ func countFailedTx(statusMap map[string]bool) int {
 
 func monitorTxFailures(config *Config, nodes []*Node, txInfo *BlockTxInfo) {
 	if txInfo != nil {
-		if len(txInfo.TxHashes) > 0 {
+		blockTxCnt := len(txInfo.TxHashes)
+		metrics.GetOrRegisterHistogram(blockTxCountPattern).Update(int64(blockTxCnt))
+
+		logrus.Debug(fmt.Sprintf("Block (%d) tx count: %d", txInfo.Height, blockTxCnt))
+
+		if blockTxCnt > 0 {
 			index := int(time.Now().UnixNano() % int64(len(nodes)))
 			statusMap, err := nodes[index].FetchBlockReceiptStatus(config.NodeHeightReport.TimedCounterConfig, txInfo.Height)
 			if err != nil {
@@ -174,6 +182,8 @@ func monitorTxFailures(config *Config, nodes []*Node, txInfo *BlockTxInfo) {
 				}
 			}
 		}
+	} else {
+		metrics.GetOrRegisterHistogram(blockTxCountPattern).Update(0)
 	}
 }