-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protoc and mockery #107
base: main
Are you sure you want to change the base?
Conversation
…pc files, and creating SSL certificates. Also, made version changes for protoc and PostgreSQL, updated code comments, and generated SDK mocks. Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
Warning Rate Limit Exceeded@rodneyosodo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 32 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates focus on improving testing and code generation across the project. Key changes include updating the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (4)
grpc/overlay.pb.go
is excluded by:!**/*.pb.go
grpc/overlay_grpc.pb.go
is excluded by:!**/*.pb.go
grpc/requests.pb.go
is excluded by:!**/*.pb.go
grpc/responses.pb.go
is excluded by:!**/*.pb.go
Files selected for processing (4)
- Makefile (2 hunks)
- pkg/mpesa/middleware/database/postgres/database_test.go (1 hunks)
- pkg/mpesa/mocks/SDK.go (1 hunks)
- pkg/mpesa/sdk.go (1 hunks)
Additional comments: 8
Makefile (3)
- 85-85: The update of
mockery
tov2.42.0
is correctly implemented with thego install
command. This ensures that the specified version ofmockery
is used for generating mocks, aligning with the PR objectives.- 87-87: The modification to the
go test
command to exclude specific packages (example|cmd|cli|mocks
) from test coverage is a good practice. It focuses test coverage on the most relevant parts of the codebase. However, ensure that all necessary packages are included in the tests and that no critical package is inadvertently excluded.- 105-105: Adjustments in the
proto
target forgrpc/responses.proto
are mentioned, but the specific changes are not visible in the provided code snippet. It's important to ensure that these adjustments are consistent with the project's gRPC schema requirements and do not introduce any breaking changes.pkg/mpesa/mocks/SDK.go (2)
- 1-1: The update to the code generation tool version (
mockery v2.42.0
) in the file header is correctly documented. This aligns with the PR's objective of updating tool versions and ensures consistency in the generated mocks.- 3-3: Adding a copyright notice for
MpesaOverlay
at the top of the file is a good practice for copyright management. It helps clarify the ownership and licensing of the generated code, aligning with legal and copyright considerations.pkg/mpesa/middleware/database/postgres/database_test.go (1)
- 46-46: The PostgreSQL container version has been updated from "15.1-alpine" to "16.1-alpine". This is a good practice to keep dependencies up-to-date. However, ensure that this version is compatible with the rest of your project's dependencies and that all tests pass with this new version.
pkg/mpesa/sdk.go (2)
- 56-56: The updated
go:generate mockery
directive now includes several new options: specifying an output directory (--output=./mocks
), filename customization (--filename SDK.go
), and quiet mode operation (--quiet
). Additionally, a copyright notice is appended as a comment (--note "Copyright (c) MpesaOverlay. All rights reserved."
). These changes enhance the mock generation process by providing more control over the output and reducing noise during generation. However, ensure that the specified output directory (./mocks
) exists or is created as part of the build process to avoid any issues with mock generation.- 53-59: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The file starts with a copyright notice, which is a good practice for protecting intellectual property and ensuring compliance with licensing requirements. This aligns with the PR's objectives of adding copyright notices to the codebase.
Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
…pc files, and creating SSL certificates. Also, made version changes for protoc and PostgreSQL, updated code comments, and generated SDK mocks.
What type of PR is this?
Related Tickets & Documents
Added/updated tests?
Added/updated documentation
Notes