Dev #17
Merged
Dev #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup of old files
Removed reward tokens
…ock and deployedContracts.ts
New feature branch
Tournament updated
xrave110
reviewed
Feb 12, 2024
| * @notice Allows the players to stake their LP token to register for the tournament | ||
| */ | ||
| function stakeLPToken() public { | ||
| require(!isPlayer(msg.sender), "You have already staked"); |
There was a problem hiding this comment.
Consider of changing to modifier.
More gas efficient is using if statement and revert with some predefined error like:
error AlreadyStaked();
..
..
if({condition}
{
revert AlreadyStaked();
}
| * @param _storedMove The move the stored player made | ||
| */ | ||
| function resolveGame(address _senderAddr, uint8 _senderMove, address _storedAddr, uint8 _storedMove) internal { | ||
| if(_senderMove == _storedMove) { |
| * @param _points 0 = lost, 1 = draw, 2 = won | ||
| */ | ||
| function updateScore(address _player, uint8 _points) internal { | ||
| if(_player == address(0)) return; // We don't update VRF score |
There was a problem hiding this comment.
Most code could be done in a front end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Concise description of proposed changes, We recommend using screenshots and videos for better description
Additional Information
Related Issues
Closes #{issue number}
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: