-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod1introducer 1level recursion verifier in the RecursionCircuit & PlonkyPOD #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
131b784
to
c4435cc
Compare
…e RecursiveCircuit
…OD1-introducer verifiers
…r proof verification with the PlonkyButNotPlonkyPOD
…ork. Add an example of IntroducerCircuitTrait (ExampleIntroducer) which verifies a Schnorr signature, that is, the RecursionCircuit will verify the plonky2 proof of that circuit (together with M Schnorr sigs, and N cyclic-recursion proofs from previous RecursionCircuits
…rdata, recursive test now also tests pod1introducer 1lvl recursion verification
dde6c4c
to
758e70f
Compare
(rebased to latest |
e52040e
to
ff20307
Compare
…et the POD1-Introducer recursive verifier
ff20307
to
aed3206
Compare
Ready for review @ludns |
ax0
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the 1-level recursive verification of the
POD1-Introducer
proofs inside theRecursionCircuit
.In order to do a soft transition from the old RecursiveCircuit to the new one which verifies the POD1-Introducer proofs, a new parameter
L
is introduced.With this, each iteration of the
RecursionCircuit
does:OpsExecutor
POD1-Introducer
proof verifications (this is 1-level recursion)InnerCircuit
logics (in practice theSchnorrPODGadget
logic)RecursionCircuit
proof verifications (this is infinite-level recursion / cyclic recursion)In the PEX code, this is currently used with
L=0
, so in practice the POD1-Introducer is 'disabled' (0 of them are verified); but to use the POD1-Introducer recursive verifier in the RecursiveCircuit, we just need to:L=1
(or other value >=1)IntroducerCircuit
logic (eg. doing the babyjubjub verification there) (and use it in pex)