Move RpoRandomCoin to crate #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al-Kindi-0
force-pushed
the
al-rporandomcoin
branch
from
4345ab1 to
6cd6877
Compare
bobbinth
approved these changes
Dec 19, 2023
src/rand/rpo.rs
Outdated
Comment on lines
50
to
51
| let digest = Rpo256::hash_elements(seed); | ||
| let digest_elem = digest.as_elements(); |
There was a problem hiding this comment.
nit: should we use the same approach was we use on line 68 below. For example:
let digest: Word = Rpo256::hash_elements(seed).into();
src/rand/mod.rs
Outdated
Comment on lines
9
to
12
| /// Pseudo-random basefield elements generator. | ||
| /// | ||
| /// An instance can be used to draw, uniformly at random, basefield elements as well as `Word`s. | ||
| pub trait RandFeltsGen { |
There was a problem hiding this comment.
Not sure if I like RandFeltsGen better than Rng. Should we just go with Rng? Or maybe FeltRng?
Also minor nit: on line 9 I'd probably say just: "Pseudo-random element generator."
There was a problem hiding this comment.
Makes sense! Updated to FeltRng and changed the comment.
|
Two other things for this PR:
|
nits: minor chore: update log and readme
Al-Kindi-0
force-pushed
the
al-rporandomcoin
branch
from
7bcc972 to
9ee3d87
Compare
|
|
Makes sense. Done! |
|
Thank you! |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This moves the
RpoRandomCointo thecryptocrate and defines a trait for generating randomFeltandWordon it.Checklist before requesting a review
nextaccording to naming convention.