Introduce SmtProof
#270
Merged
Introduce SmtProof
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
requested changes
Feb 5, 2024
bobbinth
requested changes
Feb 6, 2024
|
bobbinth
approved these changes
Feb 6, 2024
Comment on lines
+127
to
+136
| /// Returns the number of entries stored in the leaf | ||
| pub fn num_entries(&self) -> u64 { | ||
| match self { | ||
| SmtLeaf::Empty(_) => 0, | ||
| SmtLeaf::Single(_) => 1, | ||
| SmtLeaf::Multiple(entries) => { | ||
| entries.len().try_into().expect("shouldn't have more than 2^64 entries") | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Realistically, it is unlikely that the number of entries in a leaf would be more than
This was referenced Feb 6, 2024
bobbinth
pushed a commit
that referenced
this pull request
Feb 14, 2024
* add conversion for `SmtLeaf` * introduce `SmtProof` scaffolding * implement `verify_membership()` * SmtLeaf: knows its index * `SmtLeaf::index` * `SmtLeaf::get_value()` returns an Option * fix `verify_membership()` * impl `SmtProof::get` * impl `into_parts()` * `SmtProof::compute_root` * use `SmtProof` in `Smt::open` * `SmtLeaf` constructors * Vec * impl `Error` for `SmtLeafError` * fix std Error * move Word/Digest conversions to LeafIndex * `SmtProof::new()` returns an error * `SparseMerkleTree::path_and_leaf_to_opening` * `SmtLeaf`: serializable/deserializable * `SmtProof`: serializable/deserializable * add tests for SmtLeaf serialization * move `SmtLeaf` to submodule * use constructors internally * fix docs * Add `Vec` * add `Vec` to tests * no_std use statements * fmt * `Errors`: make heading * use `SMT_DEPTH` * SmtLeaf single case: check leaf index * Multiple case: check consistency with leaf index * use `pub(super)` instead of `pub(crate)` * use `pub(super)` * `SmtLeaf`: add `num_entries()` accessor * Fix `SmtLeaf` serialization * improve leaf serialization tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #251
This PR required a change in
SmtLeaf. Specifically, forSmtProof::get(key)to know if it contains a value forkey,SmtLeafneeds to know its index in theSmt.This means that constructing a leaf from entries (
Vec<RpoDigest, Word>) is no longer possible, because in the case where no entries are provided (leading to an empty leaf), we have no way to know the leaf index. This lead to adding multiple constructors (which some are able to constructor anSmtLeafwithout error).Also note that
SmtProof::new()doesn't return an error (contrary toTieredSmtProof). This is because the only possible error would be ifMerklePathdoesn't have length 64. However,SparseMerkleTree::OpeningrequiresFrom<(MerklePath, SmtLeaf)>- that is, we already have the assumption there that theMerklePathis of proper length. I kept that assumption inSmtProof. We could potentially add adebug_assert, orexpect()it away inopen(), as is done withTieredSmtProof.This change would also impact the
node'sNullifierProof: it would need to be changed to also include theleaf_index. However, I don't see a way around it, unless I'm missing something.