-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repo to be compatible with Winterfell 0.8 #275
Conversation
3b59d3f
to
b2b6fc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a few small comments inline.
b2b6fc5
to
9c69ec4
Compare
9c69ec4
to
3055076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Overcastan - before we merge this, we'll need to create corresponding PRs in Miden VM and potentially miden base/node/client. |
3055076
to
587ae28
Compare
|
This PR updates the repo to be compatible with new 0.8 version of the Winterfell.
This update contains change in creation of the
Felt
from theu64
(from()
->try_from().unwrap()
) and a small update in serialization and deserialization of vectors ofFelt
s andRpoDigest
s.