Documented git submodules for building #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
One note: in the current |
Should we close this PR then or should we merge it in case it's needed in the future? |
|
I'd keep it open but wouldn't merge yet. After we figure how #293 is going to work, we'll either merge or close this. |
bobbinth
force-pushed
the
next
branch
2 times, most recently
from
ea484e6 to
43fe7a1
Compare
|
Closing this as stale as we probably no longer need the submodules functionality here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I propose the addition of documentation to the README.md file of this repo. Documenting the need to use git submodules to be able to build Miden crypto because of the dependency on https://github.com/PQClean/PQClean