Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reproducible builds #296

Merged
merged 10 commits into from
Mar 23, 2024
Merged

Add reproducible builds #296

merged 10 commits into from
Mar 23, 2024

Conversation

phklive
Copy link
Contributor

@phklive phklive commented Mar 22, 2024

In this PR I propose the addition of multiple files and improvements enabling more reproducible builds, easier testing, linting and overall repo management.

Closes: #282

@phklive phklive requested a review from bobbinth March 22, 2024 22:27
@phklive phklive marked this pull request as ready for review March 22, 2024 22:41
@phklive
Copy link
Contributor Author

phklive commented Mar 22, 2024

Followed all demands in #282

Kept pre-commit.yml file update for another PR because it is more involved considering we need to make a refactor of the file.

Opened an issue here: #297

I have opened 3 issues, 1 in Node, 1 in Base, 1 in Crypto to take care of all pre-commit.yml files in the 3 repos at once in the future.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! I pushed a couple of commits with some minor changes, but other than that - this is good to merge.

@bobbinth bobbinth merged commit bb95b0b into next Mar 23, 2024
11 checks passed
@bobbinth bobbinth deleted the phklive-reproducible-builds branch March 23, 2024 07:32
@bobbinth bobbinth mentioned this pull request Mar 23, 2024
6 tasks
bobbinth added a commit that referenced this pull request Mar 24, 2024
* chore: update crate version to v0.9.0
* chore: remove deprecated re-exports
* chore: remove Box re-export
* feat: implement pure-Rust keygen and signing for RpoFalcon512 (#285)
* feat: add reproducible builds (#296)
* fix: address a few issues for migrating Miden VM  (#298)
* feat: add RngCore supertrait for FeltRng (#299)

---------

Co-authored-by: Al-Kindi-0 <82364884+Al-Kindi-0@users.noreply.github.com>
Co-authored-by: Paul-Henry Kajfasz <42912740+phklive@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants