Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding Falcon secret key basis polynomials #319

Merged
merged 7 commits into from
May 29, 2024
Merged

Fix encoding Falcon secret key basis polynomials #319

merged 7 commits into from
May 29, 2024

Conversation

Al-Kindi-0
Copy link
Collaborator

Describe your changes

Puts the field elements in the correct range before encoding them.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@Al-Kindi-0 Al-Kindi-0 requested a review from bobbinth May 28, 2024 16:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

bobbinth
bobbinth approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

This is a fix for sometimes getting errors on key deserialization, right?

@Al-Kindi-0
Copy link
Collaborator Author

Indeed, that's the aim of this PR.

@bobbinth bobbinth merged commit 8556c8f into next May 29, 2024
11 checks passed
@bobbinth bobbinth deleted the al-fix-encoding-falcon branch May 29, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Al-Kindi-0 @bobbinth @TheMenko @hackaugusto