Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dead_code warning on pairs_to_leaf when not(feature = "concurrent") #380

Merged

Conversation

Qyriad
Copy link
Contributor

@Qyriad Qyriad commented Feb 17, 2025

Trivial change to fix a warning with --no-default-features.

@bobbinth bobbinth added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Feb 22, 2025
This also moves `pairs_to_leaf()` out of the `SparseMerkleTree` trait,
also removing it from `SimpleSmt`, as `pairs_to_leaf()` is only ever
used in concurrent code for `Smt`.

This fixes a warning with `--no-default-features`.
@Qyriad Qyriad force-pushed the maint/fix-unused-pairs_to_leaf branch from 71dfb23 to 4d53cbc Compare February 24, 2025 13:55
@Qyriad Qyriad requested a review from bobbinth February 24, 2025 13:55
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit b97243c into 0xPolygonMiden:next Feb 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants