Skip to content

Commit

Permalink
apply suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
varun-doshi committed Mar 5, 2025
1 parent 1ac7837 commit 5785daf
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 20 deletions.
10 changes: 7 additions & 3 deletions crates/miden-lib/src/note/utils.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
use crate::note::{
scripts, AccountId, Asset, NoteError, NoteExecutionMode, NoteInputs, NoteRecipient, NoteTag,
NoteType, Word,
use miden_objects::{
account::AccountId,
asset::Asset,
note::{NoteExecutionMode, NoteInputs, NoteRecipient, NoteTag, NoteType},
NoteError, Word,
};

use crate::note::scripts;

/// Creates a [NoteRecipient] for the P2ID note.
///
/// Notes created with this recipient will be P2ID notes consumable by the specified target
Expand Down
4 changes: 1 addition & 3 deletions crates/miden-lib/src/transaction/errors.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
use alloc::{boxed::Box, vec::Vec};
use core::error::Error;

use miden_objects::{note::NoteMetadata, AccountDeltaError, AssetError, NoteError};
use miden_objects::{note::NoteMetadata, AccountDeltaError, AssetError, Digest, Felt, NoteError};
use thiserror::Error;

use crate::transaction::{Digest, Felt};

// TRANSACTION KERNEL ERROR
// ================================================================================================

Expand Down
11 changes: 4 additions & 7 deletions crates/miden-lib/src/transaction/inputs.rs
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
use alloc::vec::Vec;

use super::TransactionKernel;
use miden_objects::{
account::{Account, StorageSlot},
transaction::{ChainMmr, InputNote, TransactionScript},
FieldElement, Word, WORD_SIZE,
};

use super::TransactionKernel;
use crate::transaction::{
AdviceInputs, Digest, Felt, TransactionArgs, TransactionInputs, EMPTY_WORD, ZERO,
transaction::{ChainMmr, InputNote, TransactionArgs, TransactionInputs, TransactionScript},
vm::AdviceInputs,
Digest, Felt, FieldElement, Word, EMPTY_WORD, WORD_SIZE, ZERO,
};

// ADVICE INPUTS
Expand Down
9 changes: 4 additions & 5 deletions crates/miden-lib/src/transaction/outputs.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
use miden_objects::{AccountError, Word, WORD_SIZE};

use super::memory::{
MemoryOffset, ACCT_CODE_COMMITMENT_OFFSET, ACCT_DATA_MEM_SIZE, ACCT_ID_AND_NONCE_OFFSET,
ACCT_NONCE_IDX, ACCT_STORAGE_COMMITMENT_OFFSET, ACCT_VAULT_ROOT_OFFSET,
};
use crate::transaction::{
memory::{ACCT_ID_PREFIX_IDX, ACCT_ID_SUFFIX_IDX},
AccountHeader, AccountId, Felt,
use crate::transaction::memory::{ACCT_ID_PREFIX_IDX, ACCT_ID_SUFFIX_IDX};
use miden_objects::{
account::{AccountHeader, AccountId},
AccountError, Felt, Word, WORD_SIZE,
};

// STACK OUTPUTS
Expand Down
3 changes: 1 addition & 2 deletions crates/miden-lib/src/transaction/procedures/mod.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
use alloc::vec::Vec;

use kernel_v0::KERNEL0_PROCEDURES;
use miden_objects::Hasher;
use miden_objects::{Digest, Felt, Hasher};

use super::TransactionKernel;
use crate::transaction::{Digest, Felt};

// Include kernel v0 procedure hashes generated in build.rs
#[rustfmt::skip]
Expand Down

0 comments on commit 5785daf

Please sign in to comment.