feat: removed external dependencies from miden-objects #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| prettier::PrettyPrint, | ||
| Program, | ||
| }; | ||
| use assembly::Compile; |
There was a problem hiding this comment.
We can add a re-export of Compile in lib.rs and then import it from crate as well.
| Program, | ||
| }; | ||
| use assembly::Compile; | ||
| use vm_core::prettier::PrettyPrint; |
There was a problem hiding this comment.
I think we can also add a re-export of PrettyPrint.
| AdviceMap, Program, | ||
| }; | ||
| use vm_processor::{AdviceInputs, DeserializationError}; | ||
| use vm_core::mast::{MastForest, MastNodeId}; |
There was a problem hiding this comment.
Let's also add a re-export of MastForest and MastNodeId.
| use super::{ | ||
| Asset, ByteReader, ByteWriter, Deserializable, DeserializationError, Digest, Felt, Hasher, | ||
| NoteError, Serializable, Word, WORD_SIZE, ZERO, | ||
| use super::Asset; |
There was a problem hiding this comment.
Can you replace this Asset import with an import from crate? Thanks!
PhilippGackstatter
approved these changes
Mar 3, 2025
bobbinth
added
the
no changelog
|
@varun-doshi - could you fix the lints? After this, we should be good to merge. |
varun-doshi
force-pushed
the
varun/deps-object
branch
from
36a59e9 to
ebcd159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1145
removed external dependencies from
miden-objects