Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored account update details #618

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 0.3.0 (TBD)

* [BREAKING] Removed the transaction script root output from the transaction kernel (#608).
* [BREAKING] Refactored account update details (#618).

## 0.2.1 (2024-04-12)

Expand All @@ -19,7 +20,8 @@
* Improved `ProvenTransaction` serialization (#543).
* Implemented note tree wrapper structs (#560).
* [BREAKING] Migrated to v0.9 version of Miden VM (#567).
* [BREAKING] Added account storage type parameter to `create_basic_wallet` and `create_basic_fungible_faucet` (miden-lib crate only) (#587).
* [BREAKING] Added account storage type parameter to `create_basic_wallet` and `create_basic_fungible_faucet` (miden-lib
crate only) (#587).
* Removed serialization of source locations from account code (#590).

## 0.1.1 (2024-03-07) - `miden-objects` crate only
Expand Down
9 changes: 5 additions & 4 deletions miden-tx/src/prover/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ use miden_lib::transaction::{ToTransactionKernelInputs, TransactionKernel};
use miden_objects::{
notes::Nullifier,
transaction::{
AccountDetails, InputNotes, ProvenTransaction, ProvenTransactionBuilder, TransactionWitness,
AccountUpdateDetails, InputNotes, ProvenTransaction, ProvenTransactionBuilder,
TransactionWitness,
},
};
use miden_prover::prove;
Expand Down Expand Up @@ -81,12 +82,12 @@ impl TransactionProver {
.apply_delta(&account_delta)
.map_err(TransactionProverError::InvalidAccountDelta)?;

AccountDetails::Full(account)
AccountUpdateDetails::New(account)
} else {
AccountDetails::Delta(account_delta)
AccountUpdateDetails::Delta(account_delta)
};

builder.account_details(account_details)
builder.account_update_details(account_details)
},
false => builder,
};
Expand Down
4 changes: 2 additions & 2 deletions miden-tx/src/verifier/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ impl TransactionVerifier {
// build stack inputs and outputs
let stack_inputs = TransactionKernel::build_input_stack(
transaction.account_id(),
transaction.initial_account_hash(),
transaction.account_update().init_hash(),
transaction.input_notes().commitment(),
transaction.block_ref(),
);
let stack_outputs = TransactionKernel::build_output_stack(
transaction.final_account_hash(),
transaction.account_update().final_hash(),
transaction.output_notes().commitment(),
);

Expand Down
4 changes: 3 additions & 1 deletion objects/src/transaction/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ pub use executed_tx::ExecutedTransaction;
pub use inputs::{InputNote, InputNotes, ToNullifier, TransactionInputs};
pub use outputs::{OutputNote, OutputNotes, TransactionOutputs};
pub use prepared_tx::PreparedTransaction;
pub use proven_tx::{AccountDetails, ProvenTransaction, ProvenTransactionBuilder};
pub use proven_tx::{
AccountUpdate, AccountUpdateDetails, ProvenTransaction, ProvenTransactionBuilder,
};
pub use transaction_id::TransactionId;
pub use tx_args::{TransactionArgs, TransactionScript};
pub use tx_witness::TransactionWitness;
Loading
Loading