Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Block and AccountUpdataData to miden-objects #621

Merged
merged 19 commits into from
Apr 25, 2024
Merged

Moved Block and AccountUpdataData to miden-objects #621

merged 19 commits into from
Apr 25, 2024

Conversation

polydez
Copy link
Contributor

@polydez polydez commented Apr 23, 2024

Related to issue: #592

@polydez polydez requested review from hackaugusto and bobbinth April 23, 2024 03:43
bobbinth
bobbinth reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I believe this includes changes from #618 - so, I'll review both PRs here.

I left some comments inline. The main one is about making the account update structs a bit more intuitive.

bobbinth
bobbinth reviewed Apr 24, 2024
View reviewed changes
@polydez polydez force-pushed the polydez-block-to-base branch 3 times, most recently from 2acd244 to e60cfc9 Compare April 24, 2024 15:07
@polydez polydez force-pushed the polydez-block-to-base branch from e60cfc9 to 80fd73e Compare April 24, 2024 15:18
@polydez polydez requested a review from bobbinth April 24, 2024 16:02
bobbinth
bobbinth approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I made a small commit which moves some code around and re-phrases some comments - but other than that, it is ready.

@bobbinth bobbinth merged commit 579e655 into next Apr 25, 2024
9 checks passed
@bobbinth bobbinth deleted the polydez-block-to-base branch April 25, 2024 09:15
This was referenced Apr 25, 2024
Closed
Closed
bobbinth pushed a commit that referenced this pull request Apr 25, 2024
@polydez @bobbinth
feat: add Block object and refactored AccountUpdate object (#621)
7beade5
bobbinth pushed a commit that referenced this pull request Apr 26, 2024
@polydez @bobbinth
feat: add Block object and refactored AccountUpdate object (#621)
39585b4
bobbinth pushed a commit that referenced this pull request May 13, 2024
@polydez @bobbinth
feat: add Block object and refactored AccountUpdate object (#621)
5f5ea97
bobbinth pushed a commit that referenced this pull request May 14, 2024
@polydez @bobbinth
feat: add Block object and refactored AccountUpdate object (#621)
b7466ec
Fumuran pushed a commit that referenced this pull request May 23, 2024
@polydez @Fumuran
feat: add Block object and refactored AccountUpdate object (#621)
c171f14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

@hackaugusto hackaugusto Awaiting requested review from hackaugusto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polydez @bobbinth