Implement async trait DataStore using maybe-async-await macro
#725
Conversation
phklive
force-pushed
the
phklive-maybe-async-await
branch
from
dd64839 to
0425631
Compare
| @@ -37,8 +38,8 @@ lint: format fix clippy ## Runs all linting tasks at once (Clippy, fixing, forma | |||
| # --- docs ---------------------------------------------------------------------------------------- | |||
|
|
|||
| .PHONY: doc | |||
| doc: ## Generates & checks documentation | |||
| $(WARNINGS) cargo doc --all-features --keep-going --release | |||
| doc: ## Generates & checks documentation | |||
There was a problem hiding this comment.
FYI @bobbinth the miden base does not pass the doc command + doc command is not in CI should we add it and make the repo pass?
There was a problem hiding this comment.
Yes - that would be good. But if it adds a lot of work, I'd do it in a different PR.
Makefile
Outdated
| @@ -8,17 +8,18 @@ help: | |||
|
|
|||
| WARNINGS=RUSTDOCFLAGS="-D warnings" | |||
| DEBUG_ASSERTIONS=RUSTFLAGS="-C debug-assertions" | |||
| ALL_FEATURES_BUT_ASYNC=--features concurrent,default,std,testing,serde | |||
There was a problem hiding this comment.
Do we need to list default and std features here? Isn't default enabled by default and std implied by default?
There was a problem hiding this comment.
Indeed you are right.
Removed std and default from the var.
There was a problem hiding this comment.
We do not need to list default it's always on ( except if we use --no-default-features )
| @@ -37,8 +38,8 @@ lint: format fix clippy ## Runs all linting tasks at once (Clippy, fixing, forma | |||
| # --- docs ---------------------------------------------------------------------------------------- | |||
|
|
|||
| .PHONY: doc | |||
| doc: ## Generates & checks documentation | |||
| $(WARNINGS) cargo doc --all-features --keep-going --release | |||
| doc: ## Generates & checks documentation | |||
There was a problem hiding this comment.
Yes - that would be good. But if it adds a lot of work, I'd do it in a different PR.
In this PR I add conditional
asyncfor the DataStore trait using the maybe-async-await macro.